Problem/Motivation

When a editor visits a revision page for a node, the site gives the following error:

TypeError: Argument 1 passed to Drupal\siteimprove\SiteimproveUtils::getEntityUrls() must implement interface Drupal\Core\Entity\EntityInterface or be null, string given, called in modules/contrib/siteimprove/siteimprove.module on line 25

Steps to reproduce

As a user who can access both the Siteimprove and Node revisions, attempt to view the a singular revision.

Proposed resolution

Adjust call in siteimprove_toolbar() to check with how a revision page route handles nodes.

CommentFileSizeAuthor
#3 3186609-01.patch624 bytesdrieder

Comments

drieder created an issue. See original summary.

drieder’s picture

drieder commented
Issue summary: View changes
drieder’s picture

drieder commented
StatusFileSize
new 3186609-01.patch624 bytes
shawn dearmond’s picture

shawn dearmond commented
Status: Active » Reviewed & tested by the community

You're my savior dude! Thank you so much for this patch, it saved by butt today!

  • beltofte committed ff40bea on 8.x-1.x authored by drieder 
    Issue #3186609 by drieder, Shawn DeArmond: Error when viewing node...
beltofte’s picture

beltofte
Primary language Danish
Location Copenhagen 🇩🇰
commented
Status: Reviewed & tested by the community » Fixed

Thanks guys for reporting and solving this issue. I have committed the patch and tagged a 8.x-1.9 release.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.