Problem/Motivation

The module currently piggy backs of off core's "administer site configuration" permission for controlling access to both add/edit/delete layout builder styles as well as administer the configuration settings for the module. This is not ideal for sites that want to offer access to this module's config without also granting access to "administer site configuration".

Proposed resolution

Add a "manage layout builder styles" permission to controlling add/edit/delete permissions for layout builder styles.
Add a "administer layout builder styles configuration" permission for controlling access to the settings page.

User interface changes

None, other than the new permissions added.

API changes

N/A

Data model changes

Yes, need a post update hook to assign these two permissions to any role that has the "administer site configuration" permission.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

bkosborne created an issue. See original summary.

mark_fullmer’s picture

Status: Needs review » Reviewed & tested by the community

This code change appears complete -- nice (and appropriate) use of the post update hook -- and I've functionally verified that it does what it says.

bkosborne’s picture

  • bkosborne committed 7e24b3f on 8.x-1.x
    Issue #3186574 by bkosborne, mark_fullmer: Add specific permissions for...
bkosborne’s picture

Status: Reviewed & tested by the community » Fixed

Thanks for review!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.