The urls used for the preproduction and the production of 'Paybox System classic' have changed according to the linked documentation (in french, sorry about it).

They are doing pretty much the same as the old ones, but with the new ones, the user can choose which kind of credit cart he want to use.

CommentFileSizeAuthor
#12 3186017-more-url-choices-12.patch4.72 KBjcisio
#9 3186017-more-url-choices-9.patch4.71 KBjcisio
#8 3186017-more-url-choices-8.patch4.7 KBjcisio
#7 3186017-more-url-choices-7.patch3.91 KBjcisio
#6 more-url-choices.patch3.82 KBjcisio
#4 commerce_paybox_new_urls-3186017-4.patch706 bytesduaelfr
urls_changes.patch737 bytespierre-nono
NoteTechniqueMigration_CGI_vers_HMAC_v1.2.pdf1.33 MBpierre-nono

Comments

pierre-nono created an issue. See original summary.

jcisio’s picture

jcisio commented
Status: Active » Needs work

This url is not mentionned in the latest official guide (V8.0). Thus at most we could add an extra option like what we did with responsive url.

duaelfr’s picture

duaelfr
he/him
Primary language French
Location Montpellier, France
commented

That'd be great! New URLs UI looks much better then the old one ;)
As new URL are official (even if online documentation is not up-to-date) I would change them in the code without adding an extra option.
Thanks for the patch :)

duaelfr’s picture

duaelfr
he/him
Primary language French
Location Montpellier, France
commented
Status: Needs work » Needs review
StatusFileSize
new commerce_paybox_new_urls-3186017-4.patch706 bytes

According to the documentation I'd say that "RWD3 URL is now "Paybox System version Mobile" so I applied this on the latest dev version of the module to create the attached patch.

jcisio’s picture

jcisio commented
Title: Change for PAYBOX_URL and PAYBOX_SANDBOX_URL » Change for post url
Status: Needs review » Needs work

I hesistated because that was the only manual that tells about the /php/ url. I've checked again and have found another one (pp. 30):

https://www.paybox.com/wp-content/uploads/2020/03/ManuelIntegrationPaybo...

So I guess we could say this is the official new url because it is indeed better. I don't think we should replace the responsive url because someone explicitely wanted rwd url wouldn't want another url suddenly appear.

jcisio’s picture

jcisio commented
Title: Change for post url » Allow new choices of Paybox gateway url
Status: Needs work » Needs review
StatusFileSize
new more-url-choices.patch3.82 KB
jcisio’s picture

jcisio commented
StatusFileSize
new 3186017-more-url-choices-7.patch3.91 KB

There is a bug in the previous patch.

jcisio’s picture

jcisio commented
StatusFileSize
new 3186017-more-url-choices-8.patch4.7 KB

Add a test that prevents a bug in patch #6.

jcisio’s picture

jcisio commented
StatusFileSize
new 3186017-more-url-choices-9.patch4.71 KB

Do not use short array syntax.

The last submitted patch, 8: 3186017-more-url-choices-8.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Status: Needs review » Needs work

The last submitted patch, 9: 3186017-more-url-choices-9.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

jcisio’s picture

jcisio commented
Status: Needs work » Needs review
StatusFileSize
new 3186017-more-url-choices-12.patch4.72 KB

Lol I didn't run my test. I haven't ran it this time neither, but it should pass.

  • jcisio committed 031ada9 on 7.x-1.x 
    Issue #3186017 by jcisio, pierre-nono, DuaelFr: Allow new choices of...
jcisio’s picture

jcisio commented
Status: Needs review » Fixed

  • jcisio committed 8b9e8b5 on 7.x-1.x 
    Issue #3186017 by jcisio: Add test

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.