Problem/Motivation

  • Add any / own permissions to Ingresses
CommentFileSizeAuthor
#18 3185711-18.patch1.26 KBmasami
#8 3185711-8.patch7.45 KByas
#6 3185711-6.patch8.27 KByas

Issue fork cloud-3185711

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Masami created an issue. See original summary.

Masami opened merge request !37

yas made their first commit to this issue’s fork.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Active » Needs work
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@masami

Can you add the modifications in https://git.drupalcode.org/project/cloud/-/merge_requests/29/diffs like:

  • modules/cloud_service_providers/k8s/tests/src/Functional/K8sPersistentVolumeClaimTest.php
  • modules/cloud_service_providers/k8s/tests/src/Traits/K8sTestFormDataTrait.php
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs work » Needs review
StatusFileSize
new 3185711-6.patch8.27 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
StatusFileSize
new 3185711-8.patch7.45 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@masami

Thank you for the update. It looks good to me. I'll merge the patch to 8.x-2.x and 3.x and close this issue as Fixed.

  • yas committed dc9e844 on 8.x-2.x authored by Masami 
    Issue #3185711 by Masami, yas: Add any / own permissions to Ingresses

  • yas committed e173850 on 3.x authored by Masami 
    Issue #3185711 by Masami, yas: Add any / own permissions to Ingresses
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

yas closed merge request !37

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Fixed » Needs work

@masami

Re-opening this issue. Please fix my comments.

Masami opened merge request !47

Masami opened merge request !1

masami’s picture

masami commented
Status: Needs work » Needs review
StatusFileSize
new 3185711-18.patch1.26 KB

Masami closed merge request !47

Masami closed merge request !1

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@masami

Thank you for fixing the issue. It looks good to me now. I'll merge the patch to 8.x-2.x and 3.x and close this issue as Fixed.

  • yas committed c9647a3 on 8.x-2.x authored by Masami 
    Issue #3185711 by Masami, yas: Hotfix - Add any / own permissions to...

  • yas committed 384f6c3 on 3.x authored by Masami 
    Issue #3185711 by Masami, yas: Hotfix - Add any / own permissions to...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.