Problem/Motivation
Hi, I just updated Rabbit Hole to the latest Dev version that was release Nov 14, 2020. My (local instance) site became white screen of death.
I don't see another report of this. It appears to be a simple typo fix.
PHP error logs report:
PHP Fatal error: Declaration of Drupal\rabbit_hole\BehaviorSettingsManager::saveBehaviorSettings($settings, $entity_type_id, $entity_id = NULL) must be compatible with Drupal\rabbit_hole\BehaviorSettingsManagerInterface::saveBehaviorSettings(array $settings, $entity_type_id, $entity_id) in [MY PROJECT]/web/modules/contrib/rabbit_hole/src/BehaviorSettingsManager.php on line 11
Steps to reproduce
- Update Rabbit Hole to 8.x-1.x-dev to Nov. 14 release
- Run updates
- Entire site, including admin tools, is WSOD
Proposed resolution
Add "array " to
Change line 30 in BehaviorSettingsManager.php to:
public function saveBehaviorSettings(array $settings, $entity_type_id, $entity_id = NULL) {
Comments
Comment #3
matroskeenThanks for the report!
Tests were complaining about this too, but I didn't notice that :(
The fix was committed to 8.x-1.x. Tests seem fine: https://www.drupal.org/node/1408882/qa
Thank you again!
Comment #4
ccshannon commentedCool. Glad to help. :)