Possible need to change the way MenuLinkManager update menu-item and menu-tree

Problem/Motivation

MenuLinkManager::updateDefinition() currently saves the menu link entity before updating the menu tree when $persist is TRUE. This ordering causes entity hooks (e.g., pathauto's hook_entity_update) to fire while the menu tree still contains stale parent/child data. Modules that react to menu link entity saves and query the menu tree (like Pathauto for URL alias generation) receive incorrect tree information, leading to wrong menu hierarchy or broken path aliases.

Steps to reproduce

Create a parent-child menu link hierarchy using MenuLinkContent entities
Install a module (e.g., Pathauto) that implements hook_entity_update on menu_link_content and reads the menu tree
Call MenuLinkManager::updateDefinition() to change a child link's parent with $persist = TRUE
Observe that the entity hook fires before the tree is updated — the hook sees the old tree structure

Proposed resolution

In MenuLinkManager::updateDefinition(), change the order of operations:

Call updateLink() with $persist = FALSE first — this updates the in-memory definition without persisting the entity
Save the tree via MenuTreeStorage::save() with the updated definition
If the original $persist was TRUE, call updateLink() again with $persist = TRUE to persist the entity
This ensures the menu tree is always updated before entity hooks fire, so any hook (Pathauto or otherwise) that queries the tree during entity save sees the correct, updated hierarchy.