Problem/Motivation

The work committed in #3176910: Move Olivero's preload.twig documentation to @file and include variables passed for the template. to add olivero_path to Olivero's html.html.twig failed to include ending punctuation to match the rest of the documentation in the docblock.

Steps to reproduce

Check the source.

Proposed resolution

Add a period.

CommentFileSizeAuthor
#2 3180726-2.patch611 bytesmarkdorison

Comments

markdorison created an issue. See original summary.

markdorison’s picture

markdorison
he/him
commented
Status: Active » Needs review
Related issues: +#3176910: Move Olivero's preload.twig documentation to @file and include variables passed for the template.
StatusFileSize
new 3180726-2.patch611 bytes
markdorison’s picture

markdorison
he/him
commented
Priority: Normal » Minor
walangitan’s picture

walangitan commented
Status: Needs review » Reviewed & tested by the community

Patch #2 applies cleanly. Testing the theme in the browser after it was applied yielded no regressions. Marking as RTBC.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 3180726-2.patch, failed testing. View results

anmolgoyal74’s picture

anmolgoyal74 commented
Status: Needs work » Needs review

Unrelated failure.
Triggering tests again.

walangitan’s picture

walangitan commented
Status: Needs review » Reviewed & tested by the community

Thank you anmolgoyal74 for re-triggering tests after they failed to an unrelated issue, they are now passing, marking again as RTBC.

  • lauriii committed 3f8220e on 9.2.x 
    Issue #3180726 by markdorison, walangitan: Missing punctuation in...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented

Committed 3f8220e and pushed to 9.2.x. Thanks!

Leaving open for 9.1.x backport.

  • lauriii committed 2ab562f on 9.1.x 
    Issue #3180726 by markdorison, walangitan: Missing punctuation in...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Reviewed & tested by the community » Fixed

Cherry-picked to 9.1.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.