2x: Drupal\node\Controller\NodeController::add is deprecated in drupal:8.8.0 and is removed from drupal:9.0.0. Define entity form routes through the _entity_form instead through the _controller directive. See https://www.drupal.org/node/3084856

CommentFileSizeAuthor
#24 3179770-24.patch5.09 KBflocondetoile
#23 3179770-23.patch2.36 KBPooja Ganjage
#22 3179770-22.patch2.36 KBPooja Ganjage
#21 3179770-21.patch2.35 KBPooja Ganjage
#19 3179770-19.patch2.37 KBPooja Ganjage
#18 removecontroller-3179770-16.patch2.42 KBshivam kaushal
#14 3179770-14.patch2.36 KBPooja Ganjage
#13 3179770-13.patch458 bytesPooja Ganjage
#11 3179770-11.patch899 bytesPooja Ganjage
#10 3179770-10.patch898 bytesPooja Ganjage
#9 3179770-9.patch446 bytesPooja Ganjage
#8 3179770-8.patch677 bytesPooja Ganjage
#7 3179770-7.patch708 bytesPooja Ganjage
#5 3179770-5.patch681 bytesPooja Ganjage
#3 3179770-2.patch679 bytesPooja Ganjage

Comments

flocondetoile created an issue. See original summary.

flocondetoile’s picture

flocondetoile
Primary language French
Location Lyon
commented
Project: Micro Site » Micro Node
Pooja Ganjage’s picture

Pooja Ganjage commented
StatusFileSize
new 3179770-2.patch679 bytes

Hi,

Creating a patch for this issue.

Please review the patch.

Thanks.

Pooja Ganjage’s picture

Pooja Ganjage commented
Status: Active » Needs review
Pooja Ganjage’s picture

Pooja Ganjage commented
StatusFileSize
new 3179770-5.patch681 bytes

Status: Needs review » Needs work

The last submitted patch, 5: 3179770-5.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Pooja Ganjage’s picture

Pooja Ganjage commented
StatusFileSize
new 3179770-7.patch708 bytes
Pooja Ganjage’s picture

Pooja Ganjage commented
StatusFileSize
new 3179770-8.patch677 bytes
Pooja Ganjage’s picture

Pooja Ganjage commented
StatusFileSize
new 3179770-9.patch446 bytes
Pooja Ganjage’s picture

Pooja Ganjage commented
StatusFileSize
new 3179770-10.patch898 bytes
Pooja Ganjage’s picture

Pooja Ganjage commented
StatusFileSize
new 3179770-11.patch899 bytes
flocondetoile’s picture

flocondetoile
Primary language French
Location Lyon
commented

Using the entity_form, you don't need anymore to generate a Route for each node type enabled. You need only one route /site/{site}/add/{node_type} with note_type as parameter of the route, and you have to update the MicroNodeAddLocalActions and MicroNodeAddLocalTasks to update the route_name, and set the route_parameter.

The custom access still guard access to this route given the site and the node type.

Pooja Ganjage’s picture

Pooja Ganjage commented
StatusFileSize
new 3179770-13.patch458 bytes
Pooja Ganjage’s picture

Pooja Ganjage commented
StatusFileSize
new 3179770-14.patch2.36 KB
flocondetoile’s picture

flocondetoile
Primary language French
Location Lyon
commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 14: 3179770-14.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

shivam kaushal’s picture

shivam kaushal commented
Assigned: Unassigned » shivam kaushal
shivam kaushal’s picture

shivam kaushal commented
Assigned: shivam kaushal » Unassigned
Status: Needs work » Needs review
StatusFileSize
new removecontroller-3179770-16.patch2.42 KB

in #14, we cant define directly path here, and also we dont need to define path as its already defined in line47 under route collection,

Pooja Ganjage’s picture

Pooja Ganjage commented
StatusFileSize
new 3179770-19.patch2.37 KB

Status: Needs review » Needs work

The last submitted patch, 19: 3179770-19.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Pooja Ganjage’s picture

Pooja Ganjage commented
StatusFileSize
new 3179770-21.patch2.35 KB
Pooja Ganjage’s picture

Pooja Ganjage commented
StatusFileSize
new 3179770-22.patch2.36 KB
Pooja Ganjage’s picture

Pooja Ganjage commented
StatusFileSize
new 3179770-23.patch2.36 KB
flocondetoile’s picture

flocondetoile
Primary language French
Location Lyon
commented
Status: Needs work » Needs review
StatusFileSize
new 3179770-24.patch5.09 KB

  • flocondetoile authored dbabc4f on 8.x-1.x 
    Issue #3179770 by flocondetoile: Remove NodeController::add Controller
flocondetoile’s picture

flocondetoile
Primary language French
Location Lyon
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.