Problem/Motivation

aggregator_requirements() will block installation if cURL is not available. However, Guzzle does not have a hard dependency on cURL and can work without it.

Steps to reproduce

Proposed resolution

Remove the aggregator_requirements() check.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3178175.patch1.09 KBlongwave

Issue fork drupal-3178175

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

longwave created an issue. See original summary.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Active » Needs review
FileSize
3178175.patch1.09 KB
Kristen Pol’s picture

Kristen Pol
she/her
Primary language English
Location Santa Cruz, CA, USA
CreditAttribution: Kristen Pol at Itty Bitty Byte commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Bug Smash Initiative

Thanks for the issue and patch!

1) I have confirmed that Guzzle does not need cURL. See https://docs.guzzlephp.org/en/stable/overview.html

Guzzle no longer requires cURL in order to send HTTP requests.

2) The patch still applies cleanly to 9.2.

3) The code changes look good and addresses the issue in the issue summary.

4) Tests pass.

5) Manually tested by using with patch in place and installing, uninstalling, and reinstalling aggregator. There were no errors.

Looks good to me! Marking RTBC.

  • catch committed 8664915 on 9.2.x 
    Issue #3178175 by longwave, Kristen Pol: aggregator_requirements()...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Good find.

Committed 8664915 and pushed to 9.2.x. Thanks!

bitsfs made their first commit to this issue’s fork.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.