CommentFileSizeAuthor
#5 3177284-5.patch18.8 KByas
#2 3177284-2.patch15.03 KBaadil.addweb

Comments

binoli.addweb created an issue. See original summary.

aadil.addweb’s picture

aadil.addweb commented
StatusFileSize
new 3177284-2.patch15.03 KB
aadil.addweb’s picture

aadil.addweb commented
Issue summary: View changes
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Version: 3.0.0-alpha2 » 3.x-dev
Status: Active » Needs work

@binoliaddweb

Thank you for adding the test case.

+++ b/modules/cloud_service_providers/k8s/tests/src/Unit/Plugin/cloud/project/K8sCloudProjectPluginTest.php
@@ -0,0 +1,211 @@
+    $project_value_map = [
+      ['name', (object) ['value' => $random->name(8, TRUE)]],
+      ['field_username', (object) ['value' => $random->name(8, TRUE)]],
+      ['field_enable_time_scheduler', (object) ['value' => 'TRUE']],
+      ['field_enable_resource_scheduler', (object) ['value' => 'TRUE']],
+      ['field_k8s_clusters', (object) ['value' => $cluster_name]],
+      ['field_startup_time_hour', (object) ['value' => $random->name(8, TRUE)]],
+      [
+        'field_startup_time_minute',
+        (object) ['value' => $random->name(8, TRUE)],
+      ],
+      ['field_stop_time_hour', (object) ['value' => $random->name(8, TRUE)]],
+      ['field_stop_time_minute', (object) ['value' => $random->name(8, TRUE)]],
+      ['field_request_cpu', (object) ['value' => $random->name(8, TRUE)]],
+      ['field_request_memory', (object) ['value' => $random->name(8, TRUE)]],
+      ['field_pod_count', (object) ['value' => $random->name(8, TRUE)]],
+    ];

Please use K8sTestFormDataTrait::createProjectTestFormData() .

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs work » Needs review
StatusFileSize
new 3177284-5.patch18.8 KB

@binoliaddweb

I updated the patch. Thanks

Status: Needs review » Needs work

The last submitted patch, 5: 3177284-5.patch, failed testing. View results

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs work » Reviewed & tested by the community

I'll merge the patch to 8.x-2.x and 3.x and close this issue as Fixed.

  • yas committed 7fe1975 on 8.x-2.x 
    Issue #3177284 by binoli.addweb, yas: Add a test case for...

  • yas committed 683abc2 on 3.x 
    Issue #3177284 by binoli.addweb, yas: Add a test case for...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed
Related issues: +#3176614: Add a test case for K8sCloudServerTemplatePluginTest

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.