From @lauriii in #216 in #3111409: Add new Olivero frontend theme to Drupal 9.1 core as beta

+++ b/core/themes/olivero/templates/content/media.html.twig
@@ -0,0 +1,28 @@
+    not media.isPublished() ? 'media--unpublished',
media is missing from the available variables list.
CommentFileSizeAuthor
#5 3176914-5.patch522 bytessarvjeetsingh

Comments

mherchel created an issue. See original summary.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Title: [Code Review] Media is missing from the available variables list in media.html.twig » [Olivero Code Review] Media is missing from the available variables list in media.html.twig
Project: Olivero » Drupal core
Version: 8.x-1.x-dev » 9.1.x-dev
Component: Code » Olivero theme
Priority: Normal » Minor
mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Title: [Olivero Code Review] Media is missing from the available variables list in media.html.twig » Media is missing from the available variables list in Olivero's media.html.twig
mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
sarvjeetsingh’s picture

sarvjeetsingh commented
Status: Active » Needs review
StatusFileSize
new 3176914-5.patch522 bytes

Added missing variable media in the available variable list.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Status: Needs review » Reviewed & tested by the community

This looks good to me!

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented

Committed 77e7d42 and pushed to 9.2.x. Thanks!

Leaving open for 9.1.x backport.

  • lauriii committed 77e7d42 on 9.2.x 
    Issue #3176914 by sarvjeetsingh: Media is missing from the available...

  • lauriii committed 84836fc on 9.1.x 
    Issue #3176914 by sarvjeetsingh: Media is missing from the available...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Reviewed & tested by the community » Fixed

Backported to 9.1.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.