Current code uses the following snippet to create the filename for the ICS file.

$filename = 'event-' . strtolower(Html::cleanCssIdentifier($field_settings['title'])) . '.ics';

Html::cleanCssIdentifier though doesn't transliterate the $field_settings['title'] value.

As a result, if the title contains unicode characters, the following exception is thrown: InvalidArgumentException: The filename fallback must only contain ASCII characters.

CommentFileSizeAuthor
#6 ascii_only_characters_expected_in_ics_files_title-3175373-6.patch4.07 KBvensires
#5 ascii_only_characters_expected_in_ics_files_title-3175373-5.patch3.68 KBvensires
#3 ascii_only_characters_expected_in_ics_files_title-3175373-3.patch807 bytesvensires

Comments

vensires created an issue. See original summary.

vensires’s picture

vensires
Location Greece
commented
Issue summary: View changes
vensires’s picture

vensires
Location Greece
commented
Status: Active » Needs review
StatusFileSize
new ascii_only_characters_expected_in_ics_files_title-3175373-3.patch807 bytes
zekvyrin’s picture

zekvyrin commented
Status: Needs review » Needs work

I'm ok with the change, but these need to come from dependency injection, not using Drupal:: global.

+    $langcode = \Drupal::languageManager()->getCurrentLanguage()->getId();
+    $trans = \Drupal::transliteration();
vensires’s picture

vensires
Location Greece
commented
Status: Needs work » Needs review
StatusFileSize
new ascii_only_characters_expected_in_ics_files_title-3175373-5.patch3.68 KB

You 're right! Patch attached with some further cleanup.

vensires’s picture

vensires
Location Greece
commented
StatusFileSize
new ascii_only_characters_expected_in_ics_files_title-3175373-6.patch4.07 KB

Fixed a small bug in the previous patch.

zekvyrin’s picture

zekvyrin commented

Why did you remove entityTypeManager?

It's used in line 107 (pre-patch)

    $field_config = $this->entityTypeManager->getStorage('field_config')->load($field_config_name);

I see currentUser wasn't used, so it can be removed, although I had the intention of adding it to tokens. But I guess this is a another todo.

zekvyrin’s picture

zekvyrin commented

oh I see.. entityTypeManager() is a function in controllerBase. I need to test that (soon hopefully)

vensires’s picture

vensires
Location Greece
commented

currentUser() is also provided by ControllerBase ;)

  • vensires authored add86df on 8.x-1.x 
    Issue #3175373 by vensires: ASCII only characters expected in ICS file's...
zekvyrin’s picture

zekvyrin commented
Status: Needs review » Fixed

Commited. Thank you @vensires

zekvyrin’s picture

zekvyrin commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.