------ ------------------------------------------
  Line   src/Infogram.php
 ------ ------------------------------------------
  31     Function twig_render_template not found.
 ------ ------------------------------------------

 ------ --------------------------------------
  Line   src/Plugin/Filter/FilterInfogram.php
 ------ --------------------------------------
  32     Variable $id might not be defined.
 ------ --------------------------------------

 [ERROR] Found 2 errors
CommentFileSizeAuthor
#12 updated_all_files-3172602-12.patch2.42 KBsonvir249
#8 interdiff_3-8.txt2.18 KBmeghasharma
#8 updated_all_files-3172602-8.patch3.62 KBmeghasharma
#5 Screenshot 2020-09-24 at 5.20.27 PM.png585.55 KBmeena.bisht
#3 updated_files-3172602-3.patch1.22 KBmeghasharma

Comments

sonvir249 created an issue. See original summary.

meghasharma’s picture

meghasharma commented
Assigned: Unassigned » meghasharma
meghasharma’s picture

meghasharma commented
Assigned: meghasharma » Unassigned
Status: Active » Needs review
StatusFileSize
new updated_files-3172602-3.patch1.22 KB

Fixed the errors,
Have run drupal-check & rector tools and scanned upgrade_status on infogram module: No errors reported.

my_site_name_dir % vendor/bin/drupal-check -ad web/modules/contrib/infogram
 4/4 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%
                                                                                                                      
 [OK] No errors                                                                                                         
                                                                                                                        
my_site_name_dir % vendor/bin/rector process web/modules/contrib/infogram
Rector 0.8.x-dev@8896f0a
Config file: rector.yml

 12/12 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%
                                                                                                                      
 [OK] Rector is done!

please review the patch

meena.bisht’s picture

meena.bisht commented
Assigned: Unassigned » meena.bisht
meena.bisht’s picture

meena.bisht commented
Status: Needs review » Needs work
StatusFileSize
new Screenshot 2020-09-24 at 5.20.27 PM.png585.55 KB

Attaching screenshot of errors, In Patch #3 all the phpcs coding standard are not fixed .

meena.bisht’s picture

meena.bisht commented
Assigned: meena.bisht » Unassigned
meghasharma’s picture

meghasharma commented
Assigned: Unassigned » meghasharma
meghasharma’s picture

meghasharma commented
Assigned: meghasharma » Unassigned
Status: Needs work » Needs review
StatusFileSize
new updated_all_files-3172602-8.patch3.62 KB
new interdiff_3-8.txt2.18 KB

Fixed all the phpcs coding standard errors.
please review..

meena.bisht’s picture

meena.bisht commented
Assigned: Unassigned » meena.bisht
snehalgaikwad’s picture

snehalgaikwad commented
Assigned: meena.bisht » Unassigned
Status: Needs review » Reviewed & tested by the community

Reviewed patch and applies successfully. Coding standards are fixed. Tested with Drupal-check as well.

sonvir249’s picture

sonvir249 commented
Version: 8.x-1.0-beta7 » 8.x-1.x-dev
sonvir249’s picture

sonvir249 commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new updated_all_files-3172602-12.patch2.42 KB

Rerolled the batch for dev branch.

  • B2F committed 23dd679 on 8.x-1.x authored by sonvir249 
    Issue #3172602 by meghasharma, sonvir249, meena.bisht: Drupal 9...
b2f’s picture

b2f commented
Status: Needs review » Fixed

Commited to 8.x-1.0-rc1
Thanks !

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.