Closed (fixed)
Project:
Voting API Widgets
Version:
8.x-1.x-dev
Component:
Widgets
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
15 Sep 2020 at 23:20 UTC
Updated:
16 Nov 2021 at 06:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
shaundychkoComment #3
tr commentedI'm in favor of doing this, but can it be done without introducing excessive whitespace and indentation in the rendered markup?
Comment #4
tr commentedI think votingapi-widgets-summary--like.html.twig also needs to be fixed?
Comment #5
loze commentedI have a patch that fixes this as well as the issue of the 'useful' and 'like' templates not being rendered here #3024324: Twig templates for like and useful widget summaries are not being rendered
I'm going to close this in favor of that one, since there is a more complete patch there.
Comment #6
tr commentedNo, let's fix the pluralization here - the template suggestion issue in #3024324: Twig templates for like and useful widget summaries are not being rendered is unrelated and should be handled separately.
Please contribute towards improving the patch in #2.
Comment #7
loze commentedHere you go.
Comment #9
tr commentedNow that #3173374: Update composer.json has been committed we should no longer see "Composer require failure" so I retested the patch. As you can see, it shows "Build successful" but it also shows 8 new coding standards violations introduced by the patch.
Here's a re-roll of the patch to fix those coding standards.
Note that the testbot will still automatically mark this as "Needs work" because there are no actual tests yet, but if you examine the test output you should see that the coding standards violations have gone away.
EDIT: I accidentally named the interdiff with a .patch extension (should have been .txt) so I aborted the test on that file - it was never meant to be tested.
Comment #11
tr commentedCommitted #9.