Problem/Motivation

For Anonymous users that visits a page with fullPage.js this one doesn't work for known js error "Uncaught ReferenceError: Drupal is not defined". This error happens whenever there's a module that use, in its libraries, Drupal without requiring the core/drupal library dependency.

Steps to reproduce

  1. Enable fullPage.js for specific content type.
  2. Create a node of the type of content type just created.
  3. Visit the node using an anonymous session.
  4. Check the browser's console.

Proposed resolution

Add the - core/drupal dependency to the fullpagejs.libraries.yml file.

Remaining tasks

None.

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#3 fullpagejs--avoid-drupal-undefined-anonymous-users-3170279-3.patch464 bytesreinchek

Issue fork fullpagejs-3170279

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

reinchek created an issue. See original summary.

reinchek’s picture

reinchek
Location Napoli 🌋 🇵🇸
commented
Title: Avoid "Uncaught ReferenceError: Drupal is not defined" for anonymouse user. » Avoid "Uncaught ReferenceError: Drupal is not defined" for anonymous users.
reinchek’s picture

reinchek
Location Napoli 🌋 🇵🇸
commented
StatusFileSize
new fullpagejs--avoid-drupal-undefined-anonymous-users-3170279-3.patch464 bytes

Add the missing - core/drupal dependency.

  dependencies:
    - core/drupal
    - core/jquery
    - core/jquery.once
    - core/drupalSettings
reinchek’s picture

reinchek
Location Napoli 🌋 🇵🇸
commented
Status: Needs work » Needs review
reinchek’s picture

reinchek
Location Napoli 🌋 🇵🇸
commented
Status: Needs review » Reviewed & tested by the community

philipsoares made their first commit to this issue’s fork.

philipsoares opened merge request !1

philipsoares’s picture

philipsoares commented
Version: 1.0.0-beta2 » 1.0.0-beta4
Status: Reviewed & tested by the community » Fixed

Fixed. Thanks @reinchek

philipsoares’s picture

philipsoares commented
Version: 1.0.0-beta4 » 1.0.0-beta2

Fixed on 1.0.0-beta4

philipsoares closed merge request !1

philipsoares’s picture

philipsoares commented
Status: Fixed » Closed (fixed)
robertin0’s picture

robertin0 commented

thank you, it was really helpful for me