Comments

EthanT created an issue. See original summary.

ethant’s picture

StatusFileSize
new3.51 KB
ethant’s picture

ethant’s picture

StatusFileSize
new3.17 KB
oksana-c’s picture

Status: Active » Needs work

@EthanT, the addition of entity's moderation status in entity browser table is super timely. thank you!
This is a good opportunity to expose default entity status when moderation is not enabled for a specific entity type. E.g. "Published / unpublished" instead of "Not moderated".

I also recommend keeping CSS rules for `.moderation-status` selector out of this patch. Projects can target this selector within their custom themes.

ethant’s picture

ethant’s picture

Status: Needs work » Needs review
ethant’s picture

StatusFileSize
new3.56 KB
ethant’s picture

ethant’s picture

ethant’s picture

StatusFileSize
new3.18 KB
james hawthorn-byng’s picture

StatusFileSize
new4.39 KB

@EthanT I have edited you patch slightly to use dependency injection and made the new function names a bit more explicit.
Please could you review and let me know.

Thanks again for all your contributions.

ethant’s picture

Looks good to me, @james-byng !

  • James Byng committed 7f4b5d6 on 8.x-1.x authored by EthanT
    Issue #3166953 by EthanT, James Byng: Add entity moderation status to...
james hawthorn-byng’s picture

Status: Needs review » Fixed

Cool. Merged into the dev branch.
New release coming soon.

mario steinitz’s picture

Status: Fixed » Needs work

The merge left the field widget broken, as the method getStatusColumnHeader() is missing in the current dev version.

Edit: It's not been the merge itself, but the renaming of commit c8b1b6c1da86ae6d9128bab6f115af63b18940b7. There is still a reference to the old name left in line 187.

mario steinitz’s picture

StatusFileSize
new657 bytes

The attached patch fixes the error. (Didn't open another issue for the sake of a fast fix.)

james hawthorn-byng’s picture

Status: Needs work » Fixed
james hawthorn-byng’s picture

Status: Fixed » Closed (fixed)