Hello LOBsTerr,
There are some Type hinting & coding standards issues which are stated below
FILE: grequest\grequest.module
----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------
FILE: grequest\grequest.views.inc
----------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------
FILE: grequest\src\Controller\GroupMembershipRequestController.php
-------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
58 | ERROR | [x] Parameter comment must end with a full stop
-------------------------------------------------------------------------------------------
FILE: grequest\src\Entity\Form\GroupMembershipApproveForm.php
--------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
7 | WARNING | [x] Unused use statement
--------------------------------------------------------------------------------------
FILE: grequest\src\Entity\Form\GroupMembershipRejectForm.php
-------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
-------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
7 | WARNING | [x] Unused use statement
-------------------------------------------------------------------------------------
FILE: grequest\src\Entity\Form\GroupMembershipRequestForm.php
--------------------------------------------------------------------------------------
FOUND 6 ERRORS AND 1 WARNING AFFECTING 7 LINES
--------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
9 | WARNING | [x] Unused use statement
77 | ERROR | [ ] Missing short description in doc comment
82 | ERROR | [ ] Missing short description in doc comment
87 | ERROR | [ ] Missing short description in doc comment
94 | ERROR | [ ] Missing short description in doc comment
101 | ERROR | [ ] Missing short description in doc comment
--------------------------------------------------------------------------------------
FILE: grequest\src\Plugin\GroupContentEnabler\GroupMembershipRequest.php
-------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
-------------------------------------------------------------------------------------------------
FILE: grequest\src\Plugin\GroupMembershipRequestPermissionProvider.php
-----------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------------------
FILE: grequest\src\Plugin\Validation\Constraint\GroupRequestPendingCardinality.php
-----------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
-----------------------------------------------------------------------------------------------------------
FILE: grequest\src\Plugin\Validation\Constraint\GroupRequestPendingCardinalityValidator.php
--------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
50 | ERROR | [ ] Type hint "\Drupal\group\Entity\GroupContentInterface" missing for $group_content
113 | ERROR | [x] Expected 3 space(s) before asterisk; 1 found
--------------------------------------------------------------------------------------------------------------------
FILE: grequest\src\Plugin\views\field\RequestMembership.php
------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
------------------------------------------------------------------------------------
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | interdiff-3-4.txt | 829 bytes | lobsterr |
| #3 | Drupal-Coding-Standards-3165432-4.patch | 4.62 KB | lobsterr |
| #2 | Drupal-Coding-Standards-3165432-13789626.patch | 4.16 KB | vipin.mittal18 |
Comments
Comment #2
vipin.mittal18Hello LOBsTerr,
I have fixed the issues and attached the patch. Kindly review and apply to make it fit to Drupal coding standards.
Thanks
Vipin
Comment #3
lobsterr commented@vipin.mittal18 Thanks for your contribution. I have added some small fixes
FYI normally you call your patch [description words splited by underscore symbol]-[issue number]-[number of the comment in the list].patch
So, your patch name would be drupal_coding_standards-3165432-2.patch
Comment #4
lobsterr commented