Problem/Motivation

Only Drush 8.x supported. We need to support this for Drush 9+

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Comments

JayKandari created an issue. See original summary.

jaykandari’s picture

Version: 8.x-2.x-dev » 3.x-dev
guptahemant’s picture

Assigned: Unassigned » guptahemant
jaykandari’s picture

Issue tags: -DIACWAug2020 +DIACWSep2020
guptahemant’s picture

Assigned: guptahemant » Unassigned
nitesh624’s picture

Assigned: Unassigned » nitesh624

Hi I am working on it. will update in few hours

nitesh624’s picture

Assigned: nitesh624 » Unassigned
Status: Active » Needs review
StatusFileSize
new2.76 KB
guptahemant’s picture

Status: Needs review » Needs work

hi @nitesh624

I did a quick code review, here are few points please check.

  1. +++ b/src/Commands/DrushDeleteCommands.php
    @@ -0,0 +1,68 @@
    +    $this->output()->writeln(\Drupal::service('drush_delete.entity')->deleteAllEntity($type));
    

    Same here

  2. +++ b/src/Commands/DrushDeleteCommands.php
    @@ -0,0 +1,68 @@
    +    $this->output()->writeln(\Drupal::service('drush_delete.entity')->deleteAllTerms($type));
    

    Same here

+++ b/src/Commands/DrushDeleteCommands.php
@@ -0,0 +1,68 @@
+ * In addition to this file, you need a drush.services.yml

Add the proper comments here, explaining the class

Also please make sure to remove the old code for the drush commands.

Thanks

nitesh624’s picture

StatusFileSize
new3.92 KB
nitesh624’s picture

StatusFileSize
new4.2 KB
nitesh624’s picture

Status: Needs work » Needs review

jaykandari’s picture

Status: Needs review » Fixed
Issue tags: -DIACWSep2020 +DIACWOct2020

Modified slightly on top of #10. Committed & pushed to 3.x

Thank you all.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.