[warning] Invalid json in modules/contrib/amazing_multiselect/composer.json

Getting this warning when enabling the module.

CommentFileSizeAuthor
#2 3165345-2.patch313 byteskunal_singh

Comments

kunal_singh created an issue. See original summary.

kunal_singh’s picture

StatusFileSize
new313 bytes
kunal_singh’s picture

Assigned: kunal_singh » Unassigned
Status: Active » Needs review
kunal_singh’s picture

Category: Bug report » Task
kunal_singh’s picture

Issue tags: +DIACWAug2020
kkmitra’s picture

Assigned: Unassigned » kkmitra
kkmitra’s picture

Assigned: kkmitra » Unassigned
Status: Needs review » Reviewed & tested by the community

Applied the patch in #5 and it is giving no warning while installing the module. So changing the status to RTBC.

macherif’s picture

Sorry for the delay (I am having a big amount of work) is anyone is available to be added as a maintainer and apply this patch for a new release ?

kunal_singh’s picture

@macherif I would love to do that :)

macherif’s picture

@kunal_singh Thank you for your help. You are welcome as maintainer.

kunal_singh’s picture

Status: Reviewed & tested by the community » Fixed

committed and pushed!
Thank you everyone :)

macherif’s picture

Thank you @kynal_singh. We need to create a new tag of release that include your commit. And create a release.

kunal_singh’s picture

@macherif New release done.

But I noticed that the core_version_requirement is missing from the dev branch. It's only present in the 8.x-2.0 tag. I think we should update our dev branch as well.
I'm updating the dev branch and creating a new release to fix this.

kunal_singh’s picture

@macherif New release done with core_version_requirement key

kunal_singh’s picture

Status: Fixed » Closed (fixed)
macherif’s picture

@kynal_singh Great job! Many thanks ;)