Problem/Motivation

In Drupal 8.6 and later, batches are created by using a Drupal\Core\Batch\BatchBuilder object and using methods to set the options.

@ref: https://www.drupal.org/node/2875389

API changes

Update module to use BatchBuilder class

CommentFileSizeAuthor
#13 3164253-13.patch4.92 KBakshay_d
#7 3164253-7.patch4.94 KBsumachaa
#2 3164253-2.patch3.7 KBsumachaa

Comments

sumachaa created an issue. See original summary.

sumachaa’s picture

sumachaa commented
Related issues: +#3159239: Error: Using $this when not in object context
StatusFileSize
new 3164253-2.patch3.7 KB

Attached the patch for this..

The patch also fixes https://www.drupal.org/project/drush9_batch_processing/issues/3159239

sumachaa’s picture

sumachaa commented
Related issues: -#3159239: Error: Using $this when not in object context
sumachaa’s picture

sumachaa commented
Status: Active » Needs review
sumachaa’s picture

sumachaa commented
Issue summary: View changes

Status: Needs review » Needs work

The last submitted patch, 2: 3164253-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

sumachaa’s picture

sumachaa commented
StatusFileSize
new 3164253-7.patch4.94 KB

Fixing coder issues as well

sumachaa’s picture

sumachaa commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 7: 3164253-7.patch, failed testing. View results

sumachaa’s picture

sumachaa commented
Status: Needs work » Needs review
vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
commented
Status: Needs review » Needs work
Issue tags: +Needs reroll

Needs reroll.

akshay_d’s picture

akshay_d
Location Bangalore
commented
Assigned: Unassigned » akshay_d
akshay_d’s picture

akshay_d
Location Bangalore
commented
Assigned: akshay_d » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 3164253-13.patch4.92 KB

Update the patch and injected dependency
Please review.

Status: Needs review » Needs work

The last submitted patch, 13: 3164253-13.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

  • vuil committed d5ddae1 on 8.x-1.x authored by akshay_d 
    Issue #3164253 by sumachaa, akshay_d, vuil: BatchBuilder class for batch...
vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.