There are several places where the auditfiles_report_options_date_format parameter falls back to 'long'. This is now useless thanks to the new auditfiles.settings.yml file.

CommentFileSizeAuthor
#13 3161482-13.patch5.09 KBlisa.rae
#9 3161482-9.patch5.13 KBlisa.rae
#7 3161482-6.patch5.03 KBlisa.rae
#5 3161482-5.patch4.43 KBlisa.rae
#2 3161482-2.patch3.95 KBlisa.rae

Comments

LpSolit created an issue. See original summary.

lisa.rae’s picture

lisa.rae commented
Version: 8.x-2.x-dev » 8.x-3.x-dev
Category: Bug report » Task
StatusFileSize
new 3161482-2.patch3.95 KB

Moving to 3.x-dev, as this is not a bug but is code cleanup / refactoring.

Patch is attached.

lisa.rae’s picture

lisa.rae commented
Status: Active » Needs review
lpsolit’s picture

lpsolit commented
Status: Needs review » Reviewed & tested by the community

This is fine, but please fix config/install/auditfiles.settings.yml to use 'long' by default, for consistency.

lisa.rae’s picture

lisa.rae commented
StatusFileSize
new 3161482-5.patch4.43 KB

Rerolled to include suggestions from #4.

lisa.rae’s picture

lisa.rae commented
lisa.rae’s picture

lisa.rae commented
StatusFileSize
new 3161482-6.patch5.03 KB

Rerolling one more time to include a hook update to change any stored parameter option to "long" if it is a blank string.

lisa.rae’s picture

lisa.rae commented
Status: Reviewed & tested by the community » Needs work
lisa.rae’s picture

lisa.rae commented
StatusFileSize
new 3161482-9.patch5.13 KB

Rerolling patch after merging in other issues, previous patch no longer applied cleanly.

lisa.rae’s picture

lisa.rae commented
Status: Needs work » Needs review
lisa.rae’s picture

lisa.rae commented

Manually tested hook update to make sure config values were updated properly. Automated testing should cover other scenarios. Please review and report any issues found here.

lpsolit’s picture

lpsolit commented

$config->get('auditfiles.settings.auditfiles_report_options_date_format')

Is it really 'auditfiles.settings.auditfiles_report_options_date_format' or should it be 'auditfiles_report_options_date_format'?

lisa.rae’s picture

lisa.rae commented
StatusFileSize
new 3161482-13.patch5.09 KB

Well, that's what I get for not checking the exported values in the config file. Rerolling....

lpsolit’s picture

lpsolit commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

lisa.rae’s picture

lisa.rae commented

Many Thanks!

  • lhridley committed 2a56f30 on 8.x-3.x 
    Issue #3161482 by lhridley: Clean up...
lisa.rae’s picture

lisa.rae commented
Status: Reviewed & tested by the community » Fixed
lisa.rae’s picture

lisa.rae commented
Status: Fixed » Closed (fixed)