Fix 18 spelling errors for migrate specific terms

Thanks @quietone for filing this.

+++ b/core/misc/cspell/dictionary.txt
@@ -2063,7 +2056,6 @@ webtest
-whakamataku

Two whakamataku occurrences found in core/modules/migrate_drupal/tests/src/Kernel/Plugin/migrate/source/d6/VariableTranslationTest.php

$ grep -ir "whakamataku" core
core/modules/migrate_drupal/tests/src/Kernel/Plugin/migrate/source/d6/VariableTranslationTest.php:        'value' => 's:19:"Ko whakamataku heke";',
core/modules/migrate_drupal/tests/src/Kernel/Plugin/migrate/source/d6/VariableTranslationTest.php:        'site_slogan' => 'Ko whakamataku heke',

Working on this.

Done, review please, thanks.

Thanks @jameszhang023 and @quietone for the quick update.

+++ b/core/modules/migrate_drupal/tests/src/Kernel/Plugin/migrate/source/d6/VariableTranslationTest.php
@@ -4,6 +4,8 @@
+// cspell:ignore whakamataku
+

FYI, this way was accepted by @alexpott in #3155463: Fix spelling error in Drupal\filter\Plugin\migrate\process\FilterID::getSourceFilterType(), See the commit e99d322064c67c12cfcdf9af5f43c9f0a8a89e92_16_16

But both #9 and #10 are good for me. Review in details after CI run finishes.

Re #14, Nice one, let's do it? It's still in scope here, to me. Thanks!

1. $ yarn spellcheck:core
   yarn run v1.22.4
   $ cspell "**/*" "../composer/**/*" "../composer.json"
   CSpell: Files checked: 14630, Issues found: 0 in 0 files
   ✨  Done in 243.27s.
   

   Spelling check passed

2. +++ b/core/misc/cspell/dictionary.txt
   @@ -1,5 +1,4 @@
   -abantu
   
   @@ -61,7 +60,6 @@ api's
   -aptain
   
   @@ -448,7 +446,6 @@ descripcion
   -destinationproperty
   
   @@ -1156,7 +1153,6 @@ nocdata
   -nodeapi
   
   @@ -1554,7 +1550,6 @@ sebe
   -selectlist
   
   @@ -2031,10 +2026,7 @@ viewports
   -vocabfixed
   -vocablocalized
   ...
   -vocabtranslate
   
   @@ -2063,7 +2055,6 @@ webtest
   -whakamataku
   

   9 words removed in total, great! Adding the number 9 to the title.

3. +++ b/core/misc/cspell/dictionary.txt
   @@ -448,7 +446,6 @@ descripcion
   -destinationproperty
   
   +++ b/core/modules/block/tests/src/Unit/Plugin/migrate/process/BlockVisibilityTest.php
   @@ -37,7 +37,7 @@ protected function setUp(): void {
   -    $transformed_value = $this->plugin->transform([0, '', []], $this->migrateExecutable, $this->row, 'destinationproperty');
   +    $transformed_value = $this->plugin->transform([0, '', []], $this->migrateExecutable, $this->row, 'destination_property');
   

   Code changes are related to destinationproperty/destination_property mainly, and all destinationproperty/destination_property relevant changes made are in tests.

4. In addition, @quietone is one of the migrate subsystem maintainers, I am confident to set this to RTBC.

Thanks!

Great work!

1. +++ b/core/modules/field/src/Plugin/migrate/process/d6/FieldInstanceSettings.php
   @@ -6,6 +6,8 @@
   +# cspell:ignore imagefield
   

   I think we always use // instead of # for comments in PHP.

2. +++ b/core/modules/file/tests/src/Unit/Plugin/migrate/process/d6/FieldFileTest.php
   @@ -9,6 +9,8 @@
   +// cspell:ignore wambooli
   

   Can we just use a different, valid word here? It doesn't seem to be actually tested.

3. +++ b/core/modules/migrate/src/Plugin/migrate/process/Concat.php
   @@ -7,6 +7,8 @@
   +// cspell: ignore wambooli wamboolipastafazoul
   

   This only appears in comments so I think we could just reword to use something else.

4. +++ b/core/modules/migrate/tests/src/Unit/process/SubstrTest.php
   @@ -5,6 +5,8 @@
   +// cspell:ignore aptain
   

   As this only appears once I think it is cleaner to use cSpell:disable-next-line on the line before.

@quietone++

In addition to #20.1

2 coding standards messages

/var/lib/drupalci/workspace/jenkins-drupal_patches-54220/source/core/modules/field/src/Plugin/migrate/process/d6/FieldInstanceSettings.php ✗ 1 more
line 9	Perl-style comments are not allowed; use "// Comment" instead
/var/lib/drupalci/workspace/jenkins-drupal_patches-54220/source/core/modules/file/src/Plugin/migrate/field/d6/FileField.php ✗ 1 more
9	Perl-style comments are not allowed; use "// Comment" instead

$ yarn spellcheck:core
yarn run v1.22.4
$ cspell "**/*" "../composer/**/*" "../composer.json"
/Users/jungle/www/non-map/9.1.x/core/modules/views/src/Plugin/views/query/Sql.php:341:46 - Unknown word (nodereference)
/Users/jungle/www/non-map/9.1.x/core/modules/views/src/Plugin/views/query/Sql.php:342:20 - Unknown word (nodereference)
CSpell: Files checked: 14630, Issues found: 2 in 1 files

   * An example of a relationship would be a <strong>nodereference table.
   * If you have a nodereference named 'book_parent' which links to a
   * parent node, you could set up a relationship 'node_book_parent'
   * to 'node'. Then, anything that links to 'node' can link to
   * 'node_book_parent' instead, thus allowing all properties of
   * both nodes to be available in the query.

nodereference -> node reference? Meanwhile, those lines are wrapped too early.

It's a bit out of scope here, if so, not sure we should remove upserting from the dictionary here, no usages of upserting.

Looks good to me now, nice to be chipping away at these.

Random fail in CKEditorIntegrationTest

Committed 427c7ee and pushed to 9.1.x. Thanks!

Here's a backport of #28 without all the cspell stuff.

Committed c2c26f8 and pushed to 9.0.x. Thanks!

Now to get this into 8.9.x.

Committed 96a0e62 and pushed to 8.9.x. Thanks!

Backported to 8.9.x as these are only test and docs changes and keeping the tests aligned helps as moving forward.

@alexpott, thanks for committing! Changing the title back.