The current instructions in the local development guide basically requires you to install Composer and PHP with all extensions required by Drupal. This seems backwards when we actually use DDEV to avoid the manual task of installing the needed stack.

I have rewritten the guide using the recommend quick start for Drupal 9.

PS! I have tested the commands in the new guide, but I haven't built so I don't know if it looks good.

CommentFileSizeAuthor
#2 3159606-do-not-use-local-composer-1.patch4.95 KBhansfn

Issue fork official_docs-3159606

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

hansfn created an issue. See original summary.

hansfn’s picture

hansfn commented
StatusFileSize
new 3159606-do-not-use-local-composer-1.patch4.95 KB

Initial patch attached.

hansfn’s picture

hansfn commented
Related issues: +#3159557: "Local development with DDEV" guide: missing prerequisite for php-dom

Added related bug report that made my look into this.

eojthebrave’s picture

eojthebrave
he/him
Primary language English
Location Minneapolis, MN
commented
Status: Active » Needs work

Thanks for the updates @hansfn, I'm in favor of this idea. The document already requires DDEV, and this makes it not require that you also figure out how to install Composer. So +1 from me.

One nit-pick:

+++ b/source/en/guide_local_development.asciidoc
@@ -25,49 +25,62 @@ curl -L https://raw.githubusercontent.com/drud/ddev/master/scripts/install_ddev.
+If you already now know that you want some modules, for example the Devel module, you download it using "composer require". This can of course be done after installing Drupal too.

This first sentence reads a little funny to me. I think because of the "now know". Maybe remove "now"?

hansfn’s picture

hansfn commented

Yeah, that could probably be written better :-) And maybe removing "now" is enough - I don't object.

When I wrote it, I was more concerned about if the paragraph made sense to include. The idea was to, very briefly, show how you download modules when your site is controlled by Composer.

eojthebrave opened merge request !3

eojthebrave’s picture

eojthebrave
he/him
Primary language English
Location Minneapolis, MN
commented
Component: Code » Scripts
Status: Needs work » Needs review

I've been meaning to get back to this issue basically forever ... I just created a merge request with the changes from #3 and some additional edits. I walked through all the commands and confirmed they work as written. It would be great to have someone else take a look at this before merging to make sure I didn't miss anything.

amber himes matz’s picture

amber himes matz
she/her
Primary language English
Location Portland, OR USA
commented
Status: Needs review » Reviewed & tested by the community

LGTM. Thanks @eojthebrave!

  • eojthebrave committed 0b0000a on 9.0.x 
    Issue #3159606: Do not use local Composer when using DDEV
eojthebrave’s picture

eojthebrave
he/him
Primary language English
Location Minneapolis, MN
commented
Version: 9.x-dev » 9.0.x-dev
Component: Scripts » Content
Status: Reviewed & tested by the community » Fixed

This is in the 9.0.x branch. Thanks everyone. Now just need to figure out how to get it deployed to Drupal.org. :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.