Problem/Motivation

As title, visit #3122088: [Meta] Remove spelling errors from dictionary.txt and fix them for the background.

Proposed resolution

  • Remove typos attibute|uneccesarilly|colletion|constucts|worklow from core/misc/cspell/dictionary.txt
  • Replace attibute with attribute
  • Replace uneccesarilly with unnecessarily
  • Replace colletion with collection
  • Replace constucts with constructs
  • Replace worklow with workflow

Command recommended for searching typos:

$ grep -irEn --exclude-dir=core/node_modules "attibute|uneccesarilly|colletion|constucts|worklow" core composer composer.json

Verification:

Run cd core && yarn install && yarn run spellcheck:core to make sure that spelling check passes.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#10 interdiff-8-10.txt788 bytesjameszhang023
#10 3159531-10.patch6.17 KBjameszhang023
#8 3159531-8.patch6.17 KBjameszhang023
#5 interdiff-3-5.txt1.21 KBipumpkin
#5 fix_typos-3159531-5.patch7.14 KBipumpkin
#3 fix_typos-3159531-3.patch6.08 KBipumpkin

Comments

jungle created an issue. See original summary.

ipumpkin’s picture

ipumpkin
Primary language Chinese, Simplified
Location China
commented
Assigned: Unassigned » ipumpkin

working on this

ipumpkin’s picture

ipumpkin
Primary language Chinese, Simplified
Location China
commented
Status: Active » Needs review
StatusFileSize
new fix_typos-3159531-3.patch6.08 KB
jungle’s picture

jungle
He/Him
Location Chongqing, China
commented
Status: Needs review » Needs work

Thanks, @ipumpkin. One more thing, typos ( translateable|attibute|uneccesarilly|renderd|submited|typr|sevice|colletion ) should be removed from core/misc/cspell/dictionary.txt.

ipumpkin’s picture

ipumpkin
Primary language Chinese, Simplified
Location China
commented
Assigned: ipumpkin » Unassigned
Status: Needs work » Needs review
StatusFileSize
new fix_typos-3159531-5.patch7.14 KB
new interdiff-3-5.txt1.21 KB

@jungle, thanks for your feedback, patch updated.

jungle’s picture

jungle
He/Him
Location Chongqing, China
commented
Title: Fix typos: "translateable|attibute|uneccesarilly|renderd|submited|typr|sevice|colletion" in core » Fix typos: "attibute|uneccesarilly|colletion" in core
Issue summary: View changes
Status: Needs review » Needs work

Rescoping due 5 of them are covered by #3156266: Fix 70 spelling mistakes

jungle’s picture

jungle
He/Him
Location Chongqing, China
commented
Title: Fix typos: "attibute|uneccesarilly|colletion" in core » Fix typos: "attibute|uneccesarilly|colletion|constucts|worklow" in core
Issue summary: View changes

constucts -> constructs
worklow -> workflow

Adding two more, I think this is enough for mentoring a new core contributor.

jameszhang023’s picture

jameszhang023 commented
Status: Needs work » Needs review
StatusFileSize
new 3159531-8.patch6.17 KB
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Needs work

Thanks for working on this! This looks good except:

+++ b/core/modules/jsonapi/src/ResourceType/ResourceType.php
@@ -275,7 +275,7 @@ public function includeCount() {
+   * might unneccesarilly expose internal implementation details.

This one is still misspelled - should be "unnecessarily"

jameszhang023’s picture

jameszhang023 commented
StatusFileSize
new 3159531-10.patch6.17 KB
new interdiff-8-10.txt788 bytes

@longwave Thank you for pointing out the problem. I have uploaded a new patch file.

jameszhang023’s picture

jameszhang023 commented
Status: Needs work » Needs review
jungle’s picture

jungle
He/Him
Location Chongqing, China
commented
Status: Needs review » Reviewed & tested by the community 
$ grep -irEn --exclude-dir=core/node_modules "attibute|uneccesarilly|colletion|constucts|worklow" core composer composer.json
[no output]

$ cd core && yarn install && yarn run spellcheck:core
yarn install v1.22.4
[1/5] 🔍  Validating package.json...
[2/5] 🔍  Resolving packages...
success Already up-to-date.
✨  Done in 0.46s.
yarn run v1.22.4
$ cspell "**/*" "../composer/**/*" "../composer.json"
CSpell: Files checked: 14625, Issues found: 0 in 0 files
✨  Done in 249.06s.

Thanks @longwave, and @jameszhang023, it's good to go to me. Would be great to upload a patch for 9.0.x or do it later when the committer asks

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: 9.1.x-dev » 8.9.x-dev
Status: Reviewed & tested by the community » Fixed

Committed 1dfbbd8 and pushed to 9.1.x. Thanks!
Committed and pushed 10290fed28 to 9.0.x and 1029fec220 to 8.9.x. Thanks!

Backported to 8.9.x without the dictionary change.

  • alexpott committed 10290fe on 9.0.x 
    Issue #3159531 by jameszhang023, ipumpkin, jungle, longwave: Fix typos...

  • alexpott committed 1029fec on 8.9.x 
    Issue #3159531 by jameszhang023, ipumpkin, jungle, longwave: Fix typos...

  • alexpott committed 1dfbbd8 on 9.1.x 
    Issue #3159531 by jameszhang023, ipumpkin, jungle, longwave: Fix typos...
jungle’s picture

jungle
He/Him
Location Chongqing, China
commented

@jameszhang023 and @ipumpkin, Congrats on your first Drupal Core contribution!

@alexpott, thanks for committing!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.