1. Follow up on #3159331: Remove typesafe identifier checking in RefinableCalculatedGroupPermissions::mergeItems()
  2. Remove workaround from InheritedGroupPermissionCalculator
  3. Bump version dependency to 8.2
  4. Write a test that proves someone who already is a member and inherits a member can view a group just fine (this was the bug that required the workaround)
CommentFileSizeAuthor
#6 subgroup-3159332-6.patch2.85 KBkristiaanvandeneynde
#5 subgroup-3159332-5.patch1.38 KBkristiaanvandeneynde

Comments

kristiaanvandeneynde created an issue. See original summary.

kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
commented
Issue summary: View changes
kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
commented
Issue summary: View changes
Issue tags: +Group 8.2 target
kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
commented
Title: Remove typesafe workaround when Group 8.1 lands. » Remove typesafe workaround when Group 8.2 lands.
kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
commented
Title: Remove typesafe workaround when Group 8.2 lands. » Remove typesafe workaround when Group 8.3 lands.
Status: Active » Needs review
Issue tags: -Group 8.2 target
StatusFileSize
new subgroup-3159332-5.patch1.38 KB

This removes it, but let's add that test now.

kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
commented
StatusFileSize
new subgroup-3159332-6.patch2.85 KB

kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.