Issue fork date_recur-3158733

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

dpi created an issue. See original summary.

xurizaemon made their first commit to this issue’s fork.

xurizaemon opened merge request !11

dpi’s picture

dpi
Location Perth, Australia
commented

This guy #3194848: Not possible to run DrupalCI when projects require a PHP version higher than 7.3.0 via #3193440: PHP 7.4 compat/code upgrade :(

xurizaemon’s picture

xurizaemon
he/him
Location Ōtepoti, Aotearoa 🏝
commented

Ah, thanks. Now I feel like the changes in this MR aren't on the right issue.

If you'd like me to resubmit them on another issue, happy to do so. Will leave here for now, let me know if moving them would be helpful.

dpi’s picture

dpi
Location Perth, Australia
commented
Status: Active » Postponed

Blocked on #3194848: Not possible to run DrupalCI when projects require a PHP version higher than 7.3.0 and #3193440: PHP 7.4 compat/code upgrade

dpi’s picture

dpi
Location Perth, Australia
commented
Status: Postponed » Active
Related issues: +#3185082: Drupal.Arrays.Array.LongLineDeclaration make me write less readable code
  • Fixed the this->t on tests since thats not actually a thing.
  • Reverted the long setErrorByName call. Not actually a problem.
  • Changed style of return type on setup so there is no space before the type. In line with the rest of the project.
  • Reverted change to make arrays multiline. I think the sniff is goddawful. In the other PHP 7.4 MR I already added a line ignore to prevent these failures. See also #3185082: Drupal.Arrays.Array.LongLineDeclaration make me write less readable code for others who are upset with this.
dpi’s picture

dpi
Location Perth, Australia
commented

  • dpi committed ce56d66 on 3.1.x authored by xurizaemon 
    Issue #3158733 by xurizaemon, dpi: Further Drupal 9 deprecations
dpi’s picture

dpi
Location Perth, Australia
commented
Version: 3.x-dev » 3.1.x-dev
Assigned: dpi » Unassigned
Status: Active » Fixed

Merged into 3.1.x.

Tests are passing with D9.1, 9.2, 9.3 on PHP 7.3 and PHP 8.0.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.