Hello!

When are you going to change the *.info.yml for Drupal 9?

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

dcraig91 created an issue. See original summary.

andypost’s picture

Category: Feature request » Task
ankithashetty’s picture

Status: Active » Needs review
StatusFileSize
new307 bytes

Updated sliderwidget.info.yml with core_version_requirement. Please review.

Thank you!

dunebl’s picture

I have updated this patch with an added dependency to the jquery_ui_slider module because the jquery is deprecated in D9.
=>I have also changed the use of the core/jquery.ui.slider into jquery_ui_slider/slider
see #3168263: Deprecated library: The "core/jquery.ui.slider" asset library is deprecated in drupal:8.8.0 and is removed from drupal:9.0.0
Maybe we could create a special version for D9 due to this new dependency.

Zenovii_Kholyavka’s picture

Status: Needs review » Reviewed & tested by the community

Reviewed and tested this patch, it works correctly.

eliechoufani’s picture

If you're using Composer with Drupal 9 and want to apply this patch via Composer :

Add this to the repositories entry in your composer.json file :

	{
            "type": "package",
            "package": {
                "name": "drupal/sliderwidget",
                "type": "drupal-module",
                "version": "2.0",
                "source": {
                    "type": "git",
                    "url": "https://git.drupalcode.org/project/sliderwidget.git",
                    "reference": "8.x-2.x"
                }
            }
        },

Before this :

        {
            "type": "composer",
            "url": "https://packages.drupal.org/8"
        }

Then add this line in the require entry in composer.json also : "drupal/sliderwidget": "2.0"

After that, run composer update drupal/sliderwidget and composer install

Composer will download the module and apply the patch directly.

batonac’s picture

Can confirm that the a combo of #4 and #5 works. Hope to see this pushed out soon!

maxilein’s picture

Is this part of the dev?

codechefmarc’s picture

#6 was perfect for me, but I also had to add in the patch itself via the composer patches. Here is what else I added under the "extra" section of my composer.json:

"enable-patching": true,
  "patches": {
    "drupal/sliderwidget": {
      "Drupal 9 compatibility": "https://www.drupal.org/files/issues/2020-11-24/sliderwidget-Drupal_9_support-3157814-4-8.x.patch"
    }
  }
maxilein’s picture

should #6 and #10 not be part of a patch that gets invoked by "composer require 'drupal/sliderwidget:^2.0'" ?
Seems to be a lot of manual extras..

wouters_f’s picture

This may be merged.
The flow as mentioned above:

Require the dependency:
composer require drupal/jquery_ui_slider

Add repository

{
          "type": "package",
          "package": {
              "name": "drupal/sliderwidget",
              "type": "drupal-module",
              "version": "2.0",
              "source": {
                  "type": "git",
                  "url": "https://git.drupalcode.org/project/sliderwidget.git",
                  "reference": "8.x-2.x"
              }
          }
      },

Add Patch

      "drupal/sliderwidget": {
         "Drupal 9 compatibility": "https://www.drupal.org/files/issues/2020-11-24/sliderwidget-Drupal_9_support-3157814-4-8.x.patch"
      }

and then
composer require drupal/sliderwidget

Tested and works nice!
Happy 2022 to all! 🎇

dunebl’s picture

Here is the patch for D10

dunebl’s picture

Title: Drupal 9 support » Drupal 9 - 10 support

penaccaratogarciagaregnani-at-reserv made their first commit to this issue’s fork.

afagioli’s picture

afagioli’s picture

Version: 8.x-2.0 » 8.x-3.0
Status: Reviewed & tested by the community » Fixed
afagioli’s picture

Status: Fixed » Closed (fixed)
afagioli’s picture