Closed (fixed)
Project:
SliderWidget
Version:
8.x-3.0
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
8 Jul 2020 at 18:38 UTC
Updated:
4 Nov 2023 at 05:48 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
andypostComment #3
ankithashettyUpdated
sliderwidget.info.ymlwithcore_version_requirement. Please review.Thank you!
Comment #4
duneblI have updated this patch with an added dependency to the
jquery_ui_slidermodule because the jquery is deprecated in D9.=>I have also changed the use of the
core/jquery.ui.sliderintojquery_ui_slider/slidersee #3168263: Deprecated library: The "core/jquery.ui.slider" asset library is deprecated in drupal:8.8.0 and is removed from drupal:9.0.0
Maybe we could create a special version for D9 due to this new dependency.
Comment #5
Zenovii_Kholyavka commentedReviewed and tested this patch, it works correctly.
Comment #6
eliechoufani commentedIf you're using Composer with Drupal 9 and want to apply this patch via Composer :
Add this to the repositories entry in your composer.json file :
Before this :
Then add this line in the require entry in composer.json also : "drupal/sliderwidget": "2.0"
After that, run composer update drupal/sliderwidget and composer install
Composer will download the module and apply the patch directly.
Comment #8
batonac commentedCan confirm that the a combo of #4 and #5 works. Hope to see this pushed out soon!
Comment #9
maxilein commentedIs this part of the dev?
Comment #10
codechefmarc#6 was perfect for me, but I also had to add in the patch itself via the composer patches. Here is what else I added under the "extra" section of my composer.json:
Comment #11
maxilein commentedshould #6 and #10 not be part of a patch that gets invoked by "composer require 'drupal/sliderwidget:^2.0'" ?
Seems to be a lot of manual extras..
Comment #12
wouters_f commentedThis may be merged.
The flow as mentioned above:
Require the dependency:
composer require drupal/jquery_ui_sliderAdd repository
Add Patch
and then
composer require drupal/sliderwidgetTested and works nice!
Happy 2022 to all! 🎇
Comment #13
duneblHere is the patch for D10
Comment #14
duneblComment #16
afagiolihttps://www.drupal.org/project/sliderwidget/releases/8.x-3.0 supports Drupal 10
Thanks!
Comment #17
afagioliComment #18
afagioliComment #19
afagioli