Due to this change https://www.drupal.org/node/3092086, a new version is necessary for the module to be compatible with version 8.8.x and version 9.x.
Without these changes, the module will work with 8.8.x but not with version 9.x.

Attention: This change breaks with versions prior to 8.8.x, so a new release is necessary.

Comments

jtriguero created an issue. See original summary.

jtriguero’s picture

Status: Active » Needs review
StatusFileSize
new957 bytes
markdorison’s picture

Title: New release 8.8.x » Drupal 9 compatibility
tjtj’s picture

The dev version I have installed in Drupal 9 still has calls to path.alias_manager instead of path_alias.manager

# grep -rnw './' -e "path.alias_manager"
./views_base_url/src/Plugin/views/field/BaseUrl.php:45:      $container->get('path.alias_manager')
./views_base_url/tests/src/Functional/ViewsBaseUrlFieldTest.php:92:    $this->pathAliasManager = $this->container->get('path.alias_manager');

and this (I think) leads to the php error:

Symfony\Component\DependencyInjection\Exception\ServiceNotFoundExcept
ion: You have requested a non-existent service "path.alias_manager".
Did you mean this: "path_alias.manager"? in Drupal

As a result, I cannot even uninstall the module. Using the GUI throws the php error, and using drush throws a similar error:

# ./dr pm-uninstall views_base_url

In Container.php line 151:

  You have requested a non-existent service "path.alias_manager". Did you mean this: "path_alias.manager"?
tjtj’s picture

The above patch fixes this, but why wasn't it put into the dev version which claims D9 compatibility?

tlwatson’s picture

A reference to path.alias_manager , as well as the deprecated path.alias_storage , is made in ViewsBaseUrlFieldTest.php .

tlwatson’s picture

StatusFileSize
new3.36 KB

Corrected references to path.alias_manager and path.alias_storage in module code and tests.

capysara’s picture

Patch applied cleanly to 9.1.3 and works great!

Thanks!

tlwatson’s picture

StatusFileSize
new3.37 KB

Ack, I made a syntax typo! Rerolled.

capysara’s picture

Patch #9 still applies, but I'm not sure what changed from #7.

tlwatson’s picture

I was missing a closing parenthesis at the very end of #7. :)

fernly’s picture

Status: Needs review » Reviewed & tested by the community

Patch #9 applies and works for Drupal 9.1.7.

fernly’s picture

StatusFileSize
new3.5 KB

Replaced AliasManager by AliasManagerInterface because it's causing errors in combination with fixed_path_alias module.

  • rjjakes committed c7311f5 on 2.0.x authored by Fernly
    Issue #3157641 by TLHenriksen, jtriguero, Fernly, tjtj, capysara,...
rjjakes’s picture

I've committed and pushed to a new dev branch: 2.0.x
I will create a 2.0.0-beta2 release shortly.

rjjakes’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.