This module is currently unusable without Lightning Core, because it depends on Drupal\lightning_core\ComponentDiscovery. We need to remove that.

CommentFileSizeAuthor
#9 3157210-9.patch1.41 KBphenaproxima
#7 3157210-7.patch1.9 KBphenaproxima
#6 3157210-6.patch1.36 KBphenaproxima
#2 3157210-2.patch891 bytesphenaproxima

Comments

phenaproxima created an issue. See original summary.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Active » Needs review
StatusFileSize
new 3157210-2.patch891 bytes

And, patch.

grasmash’s picture

grasmash commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 3157210-2.patch, failed testing. View results

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented 
  1. +++ b/src/Telemetry.php
@@ -222,8 +221,11 @@ class Telemetry {
+    $modules = array_keys($this->moduleList->getAllAvailableInfo());

    Nit: you don't need to use array_keys() if you were to use ARRAY_FILTER_USE_KEY on array_filter(). 

  2. +++ b/src/Telemetry.php
@@ -222,8 +221,11 @@ class Telemetry {
+    return array_filter($modules, function ($module) {

    Nit: string $module

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs work » Needs review
StatusFileSize
new 3157210-6.patch1.36 KB

Fixed both nits and added a hard dependency on PHP 7+ so we can use scalar type hints.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
StatusFileSize
new 3157210-7.patch1.9 KB

Huh, it doesn't like that. Maybe without the PHP dependency?

Status: Needs review » Needs work

The last submitted patch, 7: 3157210-7.patch, failed testing. View results

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs work » Needs review
StatusFileSize
new 3157210-9.patch1.41 KB

Fer Chrissakes!

Status: Needs review » Needs work

The last submitted patch, 9: 3157210-9.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

  • phenaproxima committed f070c1a on 1.0.x 
    Issue #3157210 by phenaproxima, Wim Leers: Remove implicit dependency on...
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs work » Fixed

Screw it. I don't know why the test is failing, but I'm not waiting around to find out. Committing it.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.