XSL files should get their own internal entity.

The benefits would be:

- Prevents XSL files from being searched
- Add meta information to XSL entities
- Better groundwork for future features like "XSL selection by editor" and "Filtering for XSL list"

Roadmap:

  1. Create internal XSL entity
  2. Move uploading XSL files to own configuration form which creates these XSL entities
  3. Change FieldFormatter settings_form to provide only former uploaded XSL entities

Comments

JoCowood created an issue. See original summary.

  • JoCowood committed 7e6f8c6 on 8.x-1.x 
    Issue #3156343 by JoCowood: Updating help to describe new config entity
  • JoCowood committed 93c3b24 on 8.x-1.x
    Issue #3156343 by JoCowood: Adding documentation to formatter twig...
  • JoCowood committed a91191c on 8.x-1.x
    Issue #3156343 by JoCowood: Adding new configuration entity XSLT,...
  • JoCowood committed b8459e5 on 8.x-1.x
    Issue #3156343 by JoCowood: Removing XSL files in favour of new...
  • JoCowood committed f27bac8 on 8.x-1.x
    Issue #3156343 by JoCowood: Adding schema for configuration and former...
jocowood’s picture

jocowood
Primary language German
Location Kamp-Lintfort
commented
Status: Active » Needs review

Work done with release 8.x-1.0-alpha2

  • Added configuration entity XSLT in favour of using XSL files
  • Added corresponding forms, actions, controller, routes, menu links and default configuration
  • Refactored formatter configuration to use the new config entity
  • Updated help
  • Replaced former default XSL files by new default XSLT configuration entities

Important Note:

  • XSL files with dependencies to other local files are not supported for now, please use remote dependencies instead
  • Upgrade path: Use former XSL files as input for new XSLT templates to achieve the same behaviour as before
harkonn’s picture

harkonn commented
Status: Needs review » Reviewed & tested by the community

I tested the changes and they look good to me. Good work! :)

harkonn’s picture

harkonn commented
Assigned: jocowood » Unassigned

Removed assignee.

jocowood’s picture

jocowood
Primary language German
Location Kamp-Lintfort
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.