Problem/Motivation

As title.

Proposed resolution

For example:

-    $this->assertFalse(!empty($view->build_info['pre_render_called']), 'Make sure hook_views_pre_render is not called for the cached view.');
+    $this->assertEmpty($view->build_info['pre_render_called']);

Not sure about whether to keep or drop the $message arguments here, though.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 entity_usage_replace_empty-with-assertEmpty_NotEmpty-3155630.patch1.43 KBgena.io

Comments

gena.io created an issue. See original summary.

gena.io’s picture

gena.io commented
StatusFileSize
new entity_usage_replace_empty-with-assertEmpty_NotEmpty-3155630.patch1.43 KB
gena.io’s picture

gena.io commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

looks good to me

  • alexpott committed 59332d3e on 8.x-2.x 
    [#3155630] chore: Replace assertions involving calls to empty() with...
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.