Problem/Motivation

#2972224: Add .cspell.json to automate spellchecking in Drupal core landed, we can use cspell to check spelling errors now.

As title, this one is to fix "Drupal" related typos.

(This is a novice issue field for @jeffp)

Proposed resolution

  • Search "D rural" and replace/correct them with "Drupal"
  • Remove the typo "rural" from the dictionary file core/misc/cspell/dictionary.txt

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#7 3154533-6.patch2.42 KBjperk224
#4 3154533-3.patch2.69 KBjperk224

Comments

jungle created an issue. See original summary.

jperk224’s picture

I'm going to take this issue. @jungle created it for me to learn!

jperk224’s picture

Assigned: Unassigned » jperk224

reassigning to myself

jperk224’s picture

StatusFileSize
new2.69 KB

Uploading 1st patch.

jperk224’s picture

Status: Active » Needs review
jungle’s picture

Status: Needs review » Reviewed & tested by the community

Checked on my local,

cd core/
yarn
yarn run spellcheck:core

no errors. It's good to go to me. BTW, @jperk224 is making a patch for 9.0.x.

jperk224’s picture

StatusFileSize
new2.42 KB

Uploading a patch for 9.0.x per @jungle's request

  • xjm committed c626fbf on 9.1.x
    Issue #3154533 by jperk224, jungle: Fix "Drupal" typos in core
    

  • xjm committed d62319e on 9.0.x
    Issue #3154533 by jperk224, jungle: Fix "Drupal" typos in core
    

  • xjm committed 62cfcbe on 8.9.x
    Issue #3154533 by jperk224, jungle: Fix "Drupal" typos in core
    
    (cherry...
xjm’s picture

Status: Reviewed & tested by the community » Fixed
  • I confirmed there are no other instances of this with:
  • grep -ri "\brupal" *
  • I verified that the only changes were correcting this typo and nothing else by using git diff --staged --color-words with the patch applied locally.
  • I checked RssResponseRelativeUrlFilterTest to see how this is being used. It's essentially part of a data provider, and we're updating both the expected input and the expected output for two test cases. For one of the test cases, the expected input and output are identical; thus three total lines changed.
  • I verified that CSpell still passes with the updated dictionary in 9.1.x:
    Checking changed files...
    CSPELL: checking all files
    CSpell: Files checked: 1, Issues found: 0 in 0 files
    CSPELL: passed

Since this is just test data and the spelling error does not impact the overall coverage, this is an allowed change in the current development branch (9.1.x) as well as the production branches (9.0.x and 8.9.x). As @jungle mentioned the backport needs to only change the test data (since the dictionary is not present in those branches). Which we have in #7. :)

Adding issue credit for @jungle for mentoring, and to @jperk224 for creating this patch.

Committed #4 to 9.1.x, then committed #7 to 9.0.x and cherry-picked it to 8.9.x.

Congratulations @jperk224 on your first core contribution!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.