Closed (fixed)
Project:
Drupal core
Version:
9.1.x-dev
Component:
base system
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
24 Jun 2020 at 14:36 UTC
Updated:
8 Jul 2020 at 21:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
jperk224 commentedI'm going to take this issue. @jungle created it for me to learn!
Comment #3
jperk224 commentedreassigning to myself
Comment #4
jperk224 commentedUploading 1st patch.
Comment #5
jperk224 commentedComment #6
jungleChecked on my local,
no errors. It's good to go to me. BTW, @jperk224 is making a patch for 9.0.x.
Comment #7
jperk224 commentedUploading a patch for 9.0.x per @jungle's request
Comment #11
xjmgrep -ri "\brupal" *git diff --staged --color-wordswith the patch applied locally.RssResponseRelativeUrlFilterTestto see how this is being used. It's essentially part of a data provider, and we're updating both the expected input and the expected output for two test cases. For one of the test cases, the expected input and output are identical; thus three total lines changed.Since this is just test data and the spelling error does not impact the overall coverage, this is an allowed change in the current development branch (9.1.x) as well as the production branches (9.0.x and 8.9.x). As @jungle mentioned the backport needs to only change the test data (since the dictionary is not present in those branches). Which we have in #7. :)
Adding issue credit for @jungle for mentoring, and to @jperk224 for creating this patch.
Committed #4 to 9.1.x, then committed #7 to 9.0.x and cherry-picked it to 8.9.x.
Congratulations @jperk224 on your first core contribution!