Problem/Motivation

For full Drupal 9 compatibility we need to define revision metadata keys or we'll trigger the following deprecations on 8.9.x

  3x: The revision_user revision metadata key is not set for entity type: easy_email See: https://www.drupal.org/node/2831499
    3x in TelusEvsInstallTest::testTelusEvs from Drupal\Tests\telus_evs\Functional

  3x: The revision_created revision metadata key is not set for entity type: easy_email See: https://www.drupal.org/node/2831499
    3x in TelusEvsInstallTest::testTelusEvs from Drupal\Tests\telus_evs\Functional

  3x: The revision_log_message revision metadata key is not set for entity type: easy_email See: https://www.drupal.org/node/2831499
    3x in TelusEvsInstallTest::testTelusEvs from Drupal\Tests\telus_evs\Functional

Proposed resolution

Also EasyEmailStorage is still using an entityManager property.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#11 3154486-10.patch18.83 KBalexpott
#11 9-10-interdiff.txt841 bytesalexpott
#9 3154486-9.patch18.01 KBalexpott
#9 6-9-interdiff.txt16.95 KBalexpott
#6 3154486-6.patch1.06 KBalexpott
#2 3154486-2.patch609 bytesalexpott

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review
StatusFileSize
new 3154486-2.patch609 bytes
vijaycs85’s picture

vijaycs85
Location London, UK
commented
Status: Needs review » Reviewed & tested by the community

looks good.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Priority: Normal » Critical

Tests won';t pass on 9.0.x till this is fixed... https://www.drupal.org/project/easy_email/issues/3118492#comment-13716325

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 3154486-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Title: Add revision metadata keys » Fix D9 compatibilty: Add revision metadata keys, use entity type manager
Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new 3154486-6.patch1.06 KB
vijaycs85’s picture

vijaycs85
Location London, UK
commented
Related issues: +#3127018: Drupal 9 compatibility, +#3147104: Automated Drupal 9 compatibility fixes

Status: Needs review » Needs work

The last submitted patch, 6: 3154486-6.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs work » Needs review
StatusFileSize
new 6-9-interdiff.txt16.95 KB
new 3154486-9.patch18.01 KB

Some more fixes...

Status: Needs review » Needs work

The last submitted patch, 9: 3154486-9.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs work » Needs review
StatusFileSize
new 9-10-interdiff.txt841 bytes
new 3154486-10.patch18.83 KB

The new swiftmailer has the ability to automatically generate plain text emails. We need to disable it for these tests.

  • zengenuity committed 0f18ef8 on 2.0.x authored by alexpott 
    Issue #3154486 by alexpott: Fix D9 compatibilty: Add revision metadata...
zengenuity’s picture

zengenuity commented
Status: Needs review » Fixed

Looks good. Committed. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.