« Purge users who have never logged in for » and « Purge users who have not logged in for » is unclear and misleading.

The interface should be improved to make it clear what happens in both case.

The first one purge accounts that never logged to the site and the days,weeks or months selected started from the date of the account creation.

In the second case, the purge apply to the accounts that has been logging at least once and the days,weeks or months selected started this time from the date of the last login.

Issue fork purge_users-3154240

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

matoeil created an issue. See original summary.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Version: 8.x-2.x-dev » 4.x-dev
Priority: Normal » Minor

@matoeil could you perhaps suggest better labels or provide a MR with these changes? That would be super helpful.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Active » Postponed (maintainer needs more info)
mably’s picture

mably commented

This issue has been in "Postponed (maintainer needs more information)" for several weeks/months with no response. I'll close it as outdated in the coming weeks unless the requested information is provided. Feel free to reopen with an update if it's still relevant.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Postponed (maintainer needs more info) » Needs work
Issue tags: +Novice

@mably I think the points made are still valid, but someone has do do it. @matoeil seems inactive. Setting this to NW again. Adding novice for the texts.

mably opened merge request !57

mably’s picture

mably commented
Version: 4.x-dev » 5.x-dev
Status: Needs work » Needs review
  • Never logged in — label reworded to "Users who never logged in, with an account older than a given period"; description makes explicit that the period is counted from the account creation date.
  • Not logged in — label reworded to "Users whose last login is older than a given period"; description makes explicit that the period is counted from the last login date.

@anybody would you mind reviewing this issue's MR please?

I’ll backport it to the 4.x branch once it’s validated.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Novice

Great work @mably!! Thank you! RTBC

  • mably committed 95934ebc on 5.x 
    task: #3154240 labels are unclear and misleading

By: matoeil
By:...

mably opened merge request !58

  • mably committed 139bc83d on 4.x 
    task: #3154240 labels are unclear and misleading

By: matoeil
By:...
mably’s picture

mably commented
Status: Reviewed & tested by the community » Fixed

Thanks @anybody for the review!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.