Problem/Motivation

We need test coverage for the widgets.

Proposed resolution

Because the widgets are so AJAX-heavy, we really need a FunctionalJavascript test to ensure they work as designed.

Remaining tasks

  1. Initial test plumbing and coverage.: DONE, see #2
  2. Finish adding test coverage and remove remaining @todo
  3. Reviews/refinements.
  4. Commit.
CommentFileSizeAuthor
#7 3154076-7.patch3.44 KBdww
#2 3154076-2.patch10.1 KBdww

Comments

dww created an issue. See original summary.

dww’s picture

Status: Active » Needs review
StatusFileSize
new10.1 KB

Still a lot of @todo in here, but this is a fairly solid start.

dww’s picture

Issue tags: +Needs tests

  • dww committed fc58ea7 on 1.0.x
    Issue #3154076 by dww: Add FunctionalJavascript tests for field widgets
    
dww’s picture

Issue summary: View changes
Status: Needs review » Active

Committed and pushed #2 so we have something.
Back to active if anyone else wants to run with some of the @todo in here.

  • dww committed 77556d3 on 1.0.x
    Issue #3154076 by dww: Fix minor code style bugs in the new JS test.
    
dww’s picture

Status: Active » Needs review
StatusFileSize
new3.44 KB

Here's a bit of actual test coverage of the autocomplete widget itself...

  • dww committed d46090e on 1.0.x
    Issue #3154076 by dww: Add FunctionalJavascript test for autocomplete...
dww’s picture

Status: Needs review » Needs work

Committed #7 as d46090e and pushed.

Maybe NW is most accurate? ;)

Cheers,
-Derek

  • dww committed 53038b5 on 1.0.x
    Issue #3154076 by dww: Add explicit optgroup assertions to...

  • dww committed d5a7750 on 1.0.x
    Issue #3154076 by dww: Stop relying on 'bypass group access' for the JS...

  • dww committed 88ea062 on 1.0.x
    Issue #3154076 by dww: Remove more @todo for widget JS tests:
    
    -...
dww’s picture

Status: Needs work » Fixed
Issue tags: -Needs tests

Pushed a couple of commits to flesh out the JS widget tests in important ways. Now calling this fixed.

Yay,
-Derek

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.