Cookie Content Blockers admin menu item is currently placed in

admin/config/cookie-content-blocker

and thereby on the category level, which is against Drupal best practices. Please move it into the best fitting category instead, which might be "User interface" or "Media".

Modules should stick to that convention, otherwise the menu will fill up very quickly with bad UX. Thanks a lot in advance!

CommentFileSizeAuthor
#14 interdiff_7-14.txt491 bytespradeepjha
#14 3153757-14.patch2.14 KBpradeepjha
#13 interdiff_7-13.txt490 bytespradeepjha
#13 3153757-13.patch2.14 KBpradeepjha
#9 Screen Shot 2020-06-22 at 3.30.49 PM.png69.59 KBpradeepjha
#7 3153757-7.patch1.49 KBanybody
#5 3153757-4.patch672 bytesanybody

Comments

Anybody created an issue. See original summary.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Issue summary: View changes
pradeepjha’s picture

pradeepjha commented
Assigned: Unassigned » pradeepjha
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: pradeepjha » anybody
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Active » Needs review
StatusFileSize
new 3153757-4.patch672 bytes

Patch attached. Thanks a lot!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: anybody » Unassigned
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
StatusFileSize
new 3153757-7.patch1.49 KB

Fixed paths.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
pradeepjha’s picture

pradeepjha commented
StatusFileSize
new Screen Shot 2020-06-22 at 3.30.49 PM.png69.59 KB

Hi @Anybody
I was about to add patch on this ticket but in between you have picked and added your patch.
If you are working on any ticket then please first assign it to yourself or add a comment then work on it. Otherwise it's wasting others developer time also.

I've tested your patch it's showing under User interface section. Functionality working fine. RTBC +1 from my side.

Thanks.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Reviewed & tested by the community

Thank you and sorry @pradeepjha - we overlapped in time. Thanks for your review on this! I guess you should also be credited for your feedback.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

PS: If you'd like to improve the patch, add a "configure" link to the .info.yml file:

https://www.drupal.org/docs/creating-custom-modules/let-drupal-know-abou...

pradeepjha’s picture

pradeepjha commented
Assigned: Unassigned » pradeepjha
pradeepjha’s picture

pradeepjha commented
StatusFileSize
new 3153757-13.patch2.14 KB
new interdiff_7-13.txt490 bytes
pradeepjha’s picture

pradeepjha commented
StatusFileSize
new 3153757-14.patch2.14 KB
new interdiff_7-14.txt491 bytes

Please ignore my last patch.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: pradeepjha » Unassigned

RTBC for #7 and #14. Both do what they should. Any plans for a commit? The current implementation is against Drupal standards and messes up the admin menu.

  • Steven Buteneers committed 73cafa7 on 8.x-1.x 
    Issue #3153757 by pradeepjha, Anybody: Move admin menu item into "User...
steven buteneers’s picture

steven buteneers commented
Status: Reviewed & tested by the community » Fixed

Hi Guys,

Thanks for this simple yet very needed and effective solution. I've committed the latest patch (and added a change in the docs that was referring to the old admin path)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.