Closed (fixed)
Project:
Drupal core
Version:
8.9.x-dev
Component:
base system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
12 Jun 2020 at 08:08 UTC
Updated:
6 Jul 2020 at 08:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
alexpottComment #3
rik-dev commentedComment #4
rik-dev commentedComment #5
alexpottChange back only well-formed entities in our list of allowed html tags:Strip any tags that are not in the list of allowed html tags.This whitelist mode does not exist. This code exists so that \Drupal\Component\Utility\Xss and \Drupal\editor\EditorXssFilter\Standard can behave different. I.e. treat the list of html tags as list of allowed tags or a list of tags to remove. So something like
Defer to the ::needsRemoval() method to decide if the element is to be removed. This allows the list of tags to be treated as either a list of allowed tags or a list of denied tags.This comment needs fixing an should be re-flowed to be
Comment #6
dwwFixes all of #5. I don't see anything else to improve, but I'll let someone else RTBC. ;)
Thanks,
-Derek
Comment #7
matroskeenI believe it's good to go
Comment #8
alexpottCommitted and pushed 7430b47266 to 9.1.x and 49bdb09e7a to 9.0.x and d448b54d86 to 8.9.x. Thanks!
Backported to 8.9.x as this change is only comments.