I cannot enable the module as in the method create(), the $container is null > $container->get() gives error.

If I remove create() and __construction(), I can enable the module (and then put the methods back, ofc still not able to open the config form), but the module doesn't seem to do its job.

Issue fork webformnavigation-3151065

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

lyxuanngoc created an issue. See original summary.

rymcveigh’s picture

rymcveigh
he/him/his
commented

Looks like this issue is a result of the changes made to the WebformHandlerBase class in Webform 6.x. We no longer need a construct function.

rymcveigh opened merge request !4

rymcveigh’s picture

rymcveigh
he/him/his
commented
Status: Active » Needs review

This issue is due to the changes introduced in the newest major release of webform. I've created an MR, it includes some style adjustments that are also a result of the changes to webform.

lkacenja’s picture

lkacenja
he/him
commented
Status: Needs review » Reviewed & tested by the community

I tested this out with a clean webform 6.x install. I did not get the error on module install, but when I attempt to enable the handler on a webform. Doing so produced:

Error: Call to a member function get() on null in Drupal\webform\Plugin\WebformHandlerBase->isExcluded() (line 310 of /var/www/html/docroot/modules/contrib/webform/src/Plugin/WebformHandlerBase.php)

I installed the patch from this branch and I was able to add the handler without issue. Everything seemed to work well after that as well.

  • rymcveigh committed 4d31872 on 8.x-1.x 
    Issue #3151065 by rymcveigh: The method create() from...
rymcveigh’s picture

rymcveigh
he/him/his
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.