Problem/Motivation

In many cases an end-user is more likely to know their user name rather than UID. Also, REST and jsonapi consider the UUID to be the main identifier. Since the name and UUID are also unique in Drupal, is should be possible to authenticate with a claim on the user name or UUID.

Proposed resolution

Add support for an alternate claim on name instead of uid

Remaining tasks

add patch, add tests.

User interface changes

N/A

API changes

added auth technique

CommentFileSizeAuthor
#11 3150293-11.patch26.34 KBpwolanin
#10 3150293-10.patch26.11 KBpwolanin
#9 3150293-9.patch25.84 KBpwolanin
#8 3150293-8.patch13.33 KBpwolanin
#6 3150293-6.patch16.67 KBpwolanin
#5 3150293-5.patch9.71 KBpwolanin
#3 3150293-3.patch8.99 KBpwolanin

Comments

pwolanin created an issue. See original summary.

pwolanin’s picture

pwolanin commented
Title: Allow a claim for user name instead of uid to authenticate » Allow a claim for user name or uuid instead of uid to authenticate
Issue summary: View changes
pwolanin’s picture

pwolanin commented
Status: Active » Needs review
StatusFileSize
new 3150293-3.patch8.99 KB
pwolanin’s picture

pwolanin commented
pwolanin’s picture

pwolanin commented
StatusFileSize
new 3150293-5.patch9.71 KB

updated README

pwolanin’s picture

pwolanin commented
StatusFileSize
new 3150293-6.patch16.67 KB

Also change the users_jwt module to match.

That module still needs a test update.

Status: Needs review » Needs work

The last submitted patch, 6: 3150293-6.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

pwolanin’s picture

pwolanin commented
Status: Needs work » Needs review
StatusFileSize
new 3150293-8.patch13.33 KB

oops, that's right. the jwt module is not a dependency. A little annoying there is not another way to share a little bit of library code.

pwolanin’s picture

pwolanin commented
StatusFileSize
new 3150293-9.patch25.84 KB

Add test cases for the newly supported claims, plus resolve deprecations.

pwolanin’s picture

pwolanin commented
StatusFileSize
new 3150293-10.patch26.11 KB

clean up code style

pwolanin’s picture

pwolanin commented
StatusFileSize
new 3150293-11.patch26.34 KB

more code style cleanup

edwardchiapet’s picture

edwardchiapet
Location New York, NY
commented

Thanks, @pwolanin! The patch looks good and can be included in the next release.

pwolanin’s picture

pwolanin commented
Status: Needs review » Reviewed & tested by the community
pwolanin’s picture

pwolanin commented
Status: Reviewed & tested by the community » Fixed

  • pwolanin committed 9831e4f on 8.x-1.x 
    Issue #3150293 by pwolanin: Allow a claim for user name or uuid instead...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.