Add core_version_requirement: ^8 || ^9 to whitelabel.info.yml to designate that the module is compatible with Drupal 9. See https://drupal.org/node/3070687.

CommentFileSizeAuthor
#17 3149900-17.patch17.59 KBneograph734
#15 3149900-15.patch17.58 KBneograph734
#12 3149900-12.patch14.83 KBneograph734
#11 3149900-11.patch14.85 KBneograph734
#10 3149900-10.patch9.65 KBneograph734
#9 3149900-9.patch6.61 KBneograph734
#7 3149900-7.patch2.2 KBneograph734
#6 3149900-6.patch1.07 KBneograph734
#5 3149900-6.patch1.03 KBneograph734
#4 3149900-4.patch513 bytesneograph734
#2 3149900-2.patch416 byteskarishmaamin

Comments

karishmaamin created an issue. See original summary.

karishmaamin’s picture

karishmaamin commented
Status: Active » Needs review
StatusFileSize
new 3149900-2.patch416 bytes
neograph734’s picture

neograph734
he/him
Location Netherlands
commented

Just changing the info file will not suddenly make it work with Drupal 9. So we should at least test to see if the module works....

neograph734’s picture

neograph734
he/him
Location Netherlands
commented
StatusFileSize
new 3149900-4.patch513 bytes

Since Drupal 8.7.x is now EOL since the release of Drupal 8.9. We can safely omit the core tag entirely. This should also test on 9.

neograph734’s picture

neograph734
he/him
Location Netherlands
commented
StatusFileSize
new 3149900-6.patch1.03 KB

Ah, the error was about the test module...

neograph734’s picture

neograph734
he/him
Location Netherlands
commented
StatusFileSize
new 3149900-6.patch1.07 KB
neograph734’s picture

neograph734
he/him
Location Netherlands
commented
StatusFileSize
new 3149900-7.patch2.2 KB

Status: Needs review » Needs work

The last submitted patch, 7: 3149900-7.patch, failed testing. View results

neograph734’s picture

neograph734
he/him
Location Netherlands
commented
Status: Needs work » Needs review
StatusFileSize
new 3149900-9.patch6.61 KB

Now we are getting somewhere..

neograph734’s picture

neograph734
he/him
Location Netherlands
commented
StatusFileSize
new 3149900-10.patch9.65 KB
neograph734’s picture

neograph734
he/him
Location Netherlands
commented
StatusFileSize
new 3149900-11.patch14.85 KB
neograph734’s picture

neograph734
he/him
Location Netherlands
commented
StatusFileSize
new 3149900-12.patch14.83 KB

This should resolve almost everything.

The last submitted patch, 11: 3149900-11.patch, failed testing. View results

Status: Needs review » Needs work

The last submitted patch, 12: 3149900-12.patch, failed testing. View results

neograph734’s picture

neograph734
he/him
Location Netherlands
commented
Status: Needs work » Needs review
StatusFileSize
new 3149900-15.patch17.58 KB

Status: Needs review » Needs work

The last submitted patch, 15: 3149900-15.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

neograph734’s picture

neograph734
he/him
Location Netherlands
commented
Status: Needs work » Needs review
StatusFileSize
new 3149900-17.patch17.59 KB

This one should do it.

  • Neograph734 committed 20c39ca on 8.x-2.x 
    Issue #3149900 by Neograph734, karishmaamin: Drupal 9 compatibility
neograph734’s picture

neograph734
he/him
Location Netherlands
commented
Status: Needs review » Fixed

All done :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.