Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.The one browser test in this module needs $defaultTheme in order to be compatible with D9.
Drupal\Tests\BrowserTestBase::$defaultTheme is required in drupal:9.0.0 when using an install profile that does not set a default theme. See https://www.drupal.org/node/3083055, which includes recommendations on which theme to use.
Change record https://www.drupal.org/node/3083055
And additional problem with the test is that the $modules property is supposed to be protected.
This fixes both things.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 3146012-2-protected-modules.patch | 520 bytes | tr |
| #2 | 3146012-2-default-theme.patch | 595 bytes | tr |
Comments
Comment #2
tr commentedComment #3
naveenvalechaThis is addressed in #3122046: FileSystem::uriScheme() is deprecated in drupal:8.8.0. It will be removed from drupal:9.0.0. Use \Drupal\Core\StreamWrapper\StreamWrapperManagerInterface::getScheme() instead
Granted credit to @TR in other issue.
Comment #4
tr commentedThanks, but you missed this part of the patch:
$modules is now a protected property in tests
Perhaps it should have been in a separate patch ... here's a re-roll.
Comment #6
naveenvalechaThanks!
Committed and pushed to 8.x-3.x