Hi,

I'm testing the module on a fresh new website (Drupal 9.0.0-rc1) to see what it can do.
The import works great but it seems that the config "Selections Ids" is not taken into account.

Therefore, I would like to propose a minor correction (see patch).
It's about the way the "SelectionsIds" variable is tested.

I hope that will help !

CommentFileSizeAuthor
config_selectionIds_not_taken_into_account.patch865 bytesMyrakls

Comments

Myrakls created an issue. See original summary.

kgaut’s picture

kgaut commented

Hi,

thanks for your interest !

> The import works great but it seems that the config "Selections Ids" is not taken into account.

>Therefore, I would like to propose a minor correction (see patch).
>It's about the way the "SelectionsIds" variable is tested.

Thanks for your input !

The error was on this test :

      'selectionIds' => $selectionIds ?? $this->selectionIds,

witch is equivalent to :

      'selectionIds' => $selectionIds !== NULL ? $selectionIds : $this->selectionIds,

And on the method signature, I initialized to an empty array, which is different of NULL.

I've updated the test to

'selectionIds' => \count($selectionIds) > 0 ? $selectionIds : $this->selectionIds,

Will commit soon ! Thanks

  • Kgaut committed 62237c0 on 2.0.x authored by Myrakls 
    Issue #3145849 by Myrakls, Kgaut: Selection IDs (config BO) not taken...
kgaut’s picture

kgaut commented
Status: Needs review » Fixed
kgaut’s picture

kgaut commented

Fixed in last dev version and 2.0.0-beta3

Thanks for your report :)

Myrakls’s picture

Myrakls commented

I've updated to 2.0.0-beta3 and it works great now !
Thank you for your reactivity ! This module will help us a lot.

kgaut’s picture

kgaut commented

Let me know if I can help ;)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.