In the trait method Drupal\Tests\RandomGeneratorTrait::randomStringValidate() there is a comment with a reference to \Drupal\simpletest\WebTestBase::assertLink(). That method does not exist any more and therefore need to be changed.

CommentFileSizeAuthor
#5 3144331-5.patch670 bytesmohrerao
#3 3144331-3.patch753 bytesmohrerao
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

daffie created an issue. See original summary.

mohrerao’s picture

mohrerao CreditAttribution: mohrerao as a volunteer and at Srijan | A Material+ Company for Drupal India Association commented

We can replace the whole if statement along with comment here 

// Consecutive spaces causes issues for
    // \Drupal\simpletest\WebTestBase::assertLink().
    if (preg_match('/\s{2,}/', $string)) {
      return FALSE;
    }
mohrerao’s picture

mohrerao CreditAttribution: mohrerao as a volunteer and at Srijan | A Material+ Company for Drupal India Association commented
Status: Active » Needs review
FileSize
3144331-3.patch753 bytes

Adding a patch as commented in #2.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented

Are we sure that two spaces is OK elsewhere? e.g. in HTML two or more spaces are collapsed to one. I think this is technically an API change as previously a string with two spaces would not validate and now it will, so maybe we should just fix the comment?

mohrerao’s picture

mohrerao CreditAttribution: mohrerao as a volunteer and at Srijan | A Material+ Company for Drupal India Association commented
FileSize
3144331-5.patch670 bytes

Agreed! Just updating the comment.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Thunder commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 8be5edace1 to 9.1.x and 8fb84dad69 to 9.0.x. Thanks!

backpoorted too 9.0.x cause docs.

  • alexpott committed 8be5eda on 9.1.x 
    Issue #3144331 by mohrerao, longwave, daffie: Update comment in Drupal\...

  • alexpott committed 8fb84da on 9.0.x 
    Issue #3144331 by mohrerao, longwave, daffie: Update comment in Drupal\...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.