I'm a big believer in testing - having at least one test will help to ensure this module continues to function despite all the anticipated changes being made to Fivestar and in Drupal 9.

CommentFileSizeAuthor
#2 3143731-2-add-a-test.patch2.08 KBtr

Comments

TR created an issue. See original summary.

tr’s picture

tr commented
Status: Active » Needs review
StatusFileSize
new 3143731-2-add-a-test.patch2.08 KB

Status: Needs review » Needs work

The last submitted patch, 2: 3143731-2-add-a-test.patch, failed testing. View results

tr’s picture

tr commented
Status: Needs work » Postponed

This will pass once the Fivestar issue #3136366: hook_fivestar_widgets() implementations should explicitly include their associated libraries is fixed. Postponing on that.

  • TR committed 7deee5d on 8.x-1.x 
    Issue #3143731 by TR: Add a test
tr’s picture

tr commented
Status: Postponed » Fixed

Retest passes now that Fivestar has a new release with this new feature. Committed. We have a test!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.