Automated Drupal Rector fixes [#3141913]

Problem/Motivation

Hello project maintainers,
This is an automated issue to help make this module compatible with Drupal 9.

To read more about this effort by the Drupal Association, please read: Accelerating Drupal 9 module and theme readiness with automated patches

Periodically patches will be added to this issue that remove Drupal 9 deprecations. To stop further patches from being posted simply close this issue(any status besides Active, Needs Review or Needs work) or remove the "ProjectUpdateBotD9" tag from the issue.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

Accept automated patches until this issue is closed
If this issue is left open(status of Active, Needs Review or Needs work) and the "RectorAutoPatches" tag is left on this issue, new patches will be posted periodically if new deprecations are needed.

As the Drupal Rector project improves and is able to fix more deprecations the patches posted here will cover more of the deprecations in the module.
Leave open but stop new automated patches.
If you want to use this issue as a starting point to remove deprecations but don't want new automated patches simply leave this issue open but remove the "RectorAutoPatches" from the issue.

You can use Drupal Rector yourself to make these patches.

If you want to receive automated patches again simply add back the "RectorAutoPatches" tag.
Close it and don't use it
If the maintainers of this project don't find this issue useful they can simply close this issue(any status besides Active, Needs Review or Needs work) and no more automated patches will be posted here.

If the issue is reopened then new automated patches will be posted.

If you are using another issue(s) to work on Drupal 9 compatibility it may be useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

Apply the patch in the comment by Project Update Bot
Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Infrastructure project issue queue using the component “Bot: Drupal Rector”.

Comment	File	Size	Author
#20	3141913-19.patch	6.39 KB	heddn
#18	3141913-18.patch	3.21 KB	heddn
#15	interdiff_13-15.txt	316 bytes	adityasingh
#15	tmgmt_microsoft_3141913-15.patch	3.18 KB	adityasingh
#13	interdiff_10-13.txt	463 bytes	adityasingh
#13	tmgmt_microsoft_3141913-13.patch	3.36 KB	adityasingh
#10	interdiff_8-10.txt	491 bytes	adityasingh
#10	tmgmt_microsoft_3141913-10.patch	3.36 KB	adityasingh
#8	interdiff_6-8.txt	458 bytes	adityasingh
#8	tmgmt_microsoft_3141913-8.patch	3.64 KB	adityasingh
#6	d9-support-fixed-3141913-6.patch	3.91 KB	edycarreyes99
#6	interdiff-3141913-4-6.txt	3.91 KB	edycarreyes99
#4	interdiff-3141913-2-4.txt	3.54 KB	edycarreyes99
#4	d9-support-3141913-4.patch	3.54 KB	edycarreyes99
#2	tmgmt_microsoft.1.x-dev.rector.patch	2.13 KB	project update bot

Comments

Comment #1

23 May 2020 at 22:17

Project Update Bot created an issue. See original summary.

Comment #2

project update bot commented 23 May 2020 at 22:18

Status:

Active

» Needs review

Status	File	Size
new	tmgmt_microsoft.1.x-dev.rector.patch	2.13 KB

Patch for Build #1473

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

This patch was created using these packages:

mglaman/phpstan-drupal: 0.12.3
palantirnet/drupal-rector: 0.5.4
rector/rector-prefixed: dev-master

Debug info: Run #1473

Comment #3

project update bot commented 24 May 2020 at 06:31

Issue summary:	View changes
Issue tags:		+Drupal 9 compatibility

Fixing summary

Comment #4

edycarreyes99 commented 1 July 2020 at 05:34

Assigned:	Unassigned	» edycarreyes99
Issue summary:	View changes

Status	File	Size
new	d9-support-3141913-4.patch	3.54 KB
new	interdiff-3141913-2-4.txt	3.54 KB

The previus patch is not working and still has errors on dev branch so I fixed it on the next patch:

Microsoft Translator
Scanned on Tue, 06/30/2020 - 22:50.

4 errors found. 4 warnings found. Avoid some manual work by using drupal-rector
for fixing issues automatically or Upgrade Rector to generate patches.

web/modules/contrib/tmgmt_microsoft/src/Plugin/tmgmt/Translator/MicrosoftTransla
tor.php:
┌──────────┬──────┬──────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                            │
├──────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Fix now  │ 106  │ Call to deprecated method url() of class                     │
│          │      │ Drupal\Core\Entity\EntityInterface. Deprecated in            │
│          │      │ drupal:8.0.0 and is removed from drupal:9.0.0. Please use    │
│          │      │ toUrl() instead.                                             │
│          │      │                                                              │
│ Fix with │ 117  │ Call to deprecated method strlen() of class                  │
│ rector   │      │ Drupal\Component\Utility\Unicode. Deprecated in drupal:8.6.0 │
│          │      │ and is removed from drupal:9.0.0. Use mb_strlen() instead.   │
│          │      │                                                              │
│ Fix with │ 176  │ Call to deprecated function drupal_set_message(). Deprecated │
│ rector   │      │ in drupal:8.5.0 and is removed from drupal:9.0.0. Use        │
│          │      │ Drupal\Core\Messenger\MessengerInterface::addMessage()       │
│          │      │ instead.                                                     │
│          │      │                                                              │
└──────────┴──────┴──────────────────────────────────────────────────────────────┘

web/modules/contrib/tmgmt_microsoft/src/Tests/MicrosoftTest.php:
┌──────────┬──────┬──────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                            │
├──────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Check    │ 15   │ Class Drupal\tmgmt_microsoft\Tests\MicrosoftTest extends     │
│ manually │      │ deprecated class Drupal\tmgmt\Tests\TMGMTTestBase.           │
│          │      │                                                              │
│ Check    │ 35   │ Call to method setUp() of deprecated class                   │
│ manually │      │ Drupal\tmgmt\Tests\TMGMTTestBase.                            │
│          │      │                                                              │
│ Fix with │ 116  │ Call to deprecated function entity_create(). Deprecated in   │
│ rector   │      │ drupal:8.0.0 and is removed from drupal:9.0.0. Use The       │
│          │      │ method overriding Entity::create() for the entity type, e.g. │
│          │      │ \Drupal\node\Entity\Node::create() if the entity type is     │
│          │      │ known. If the entity type is variable, use the entity        │
│          │      │ storage's create() method to construct a new entity:         │
│          │      │                                                              │
└──────────┴──────┴──────────────────────────────────────────────────────────────┘

web/modules/contrib/tmgmt_microsoft/tmgmt_microsoft.info.yml:
┌──────────┬──────┬──────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                            │
├──────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Check    │ 0    │ Add core_version_requirement: ^8 || ^9 to designate that the │
│ manually │      │ module is compatible with Drupal 9. See                      │
│          │      │ https://drupal.org/node/3070687.                             │
│          │      │                                                              │
└──────────┴──────┴──────────────────────────────────────────────────────────────┘

web/modules/contrib/tmgmt_microsoft/tmgmt_microsoft_test/tmgmt_microsoft_test.in
fo.yml:
┌──────────┬──────┬──────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                            │
├──────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Check    │ 0    │ Add core_version_requirement: ^8 || ^9 to designate that the │
│ manually │      │ module is compatible with Drupal 9. See                      │
│          │      │ https://drupal.org/node/3070687.                             │
│          │      │                                                              │
└──────────┴──────┴──────────────────────────────────────────────────────────────┘

Comment #5

heddn

English

Nicaragua

commented 1 July 2020 at 14:03

Status:

Needs review

» Needs work

+++ b/src/Plugin/tmgmt/Translator/MicrosoftTranslator.php
@@ -99,6 +101,7 @@ class MicrosoftTranslator extends TranslatorPluginBase implements ContainerFacto
+   * @throws EntityMalformedException

This isn't needed.

+++ b/src/Plugin/tmgmt/Translator/MicrosoftTranslator.php
@@ -155,7 +158,7 @@ class MicrosoftTranslator extends TranslatorPluginBase implements ContainerFacto
+      MessengerInterface::addMessage($e->getMessage(),

An interface can't have action. This is wrong.

Comment #6

edycarreyes99 commented 1 July 2020 at 20:43

Status:

Needs work

» Needs review

Status	File	Size
new	interdiff-3141913-4-6.txt	3.91 KB
new	d9-support-fixed-3141913-6.patch	3.91 KB

I fixed the mistakes that I made and applied it on a new patch

Comment #7

heddn

English

Nicaragua

commented 1 July 2020 at 22:21

Status:

Needs review

» Needs work

+++ b/src/Plugin/tmgmt/Translator/MicrosoftTranslator.php
@@ -40,6 +40,8 @@ use Drupal\tmgmt\Translator\TranslatableResult;
+  use MessengerTrait;

One small thing left. This isn't needed as the parent class already does it.

Comment #8

adityasingh commented 2 July 2020 at 06:28

Status:

Needs work

» Needs review

Status	File	Size
new	tmgmt_microsoft_3141913-8.patch	3.64 KB
new	interdiff_6-8.txt	458 bytes

Hi @heddn
Updated patch please review.

Comment #9

heddn

English

Nicaragua

commented 2 July 2020 at 16:34

Status:

Needs review

» Needs work

+++ b/src/Plugin/tmgmt/Translator/MicrosoftTranslator.php
@@ -23,6 +22,7 @@ use GuzzleHttp\Psr7\Request;
+use Drupal\Core\Messenger\MessengerTrait;

Still left the import for the trait. So close.

Comment #10

adityasingh commented 2 July 2020 at 18:09

Status:

Needs work

» Needs review

Status	File	Size
new	tmgmt_microsoft_3141913-10.patch	3.36 KB
new	interdiff_8-10.txt	491 bytes

Hi @heddn
Made changes as you suggested #9 please have a look.
Thanks

Comment #11

heddn

English

Nicaragua

commented 9 July 2020 at 22:18

Status:

Needs review

» Needs work

+++ b/src/Tests/MicrosoftTest.php
@@ -5,6 +5,7 @@
+use Drupal;

@@ -124,7 +125,7 @@ class MicrosoftTest extends TMGMTTestBase {
+    $node = Drupal::entityTypeManager()->getStorage('node')->create(array(

Super nit: Sorry I missed this earlier. This import here isn't needed either. Just call it directly \Drupal::entityTypeManager()

Comment #12

adityasingh commented 10 July 2020 at 05:37

Assigned:

edycarreyes99

» adityasingh

I'm working on this.

Comment #13

adityasingh commented 10 July 2020 at 13:13

Assigned:	adityasingh	» Unassigned
Status:	Needs work	» Needs review

Status	File	Size
new	tmgmt_microsoft_3141913-13.patch	3.36 KB
new	interdiff_10-13.txt	463 bytes

Updated patch please review.

Comment #14

heddn

English

Nicaragua

commented 10 July 2020 at 14:05

Status:

Needs review

» Needs work

+++ b/src/Tests/MicrosoftTest.php
@@ -5,6 +5,7 @@
+use Drupal;

This leaves the un-needed import.

Comment #15

adityasingh commented 10 July 2020 at 14:14

Status	File	Size
new	tmgmt_microsoft_3141913-15.patch	3.18 KB
new	interdiff_13-15.txt	316 bytes

Remove un-needed import. Please Review.

Comment #16

adityasingh commented 10 July 2020 at 14:15

Status:

Needs work

» Needs review

Comment #17

heddn

English

Nicaragua

commented 10 July 2020 at 14:39

Status:

Needs review

» Reviewed & tested by the community

Looking good now.

Comment #18

heddn

English

Nicaragua

commented 25 November 2021 at 16:48

Status:

Reviewed & tested by the community

» Needs review

Status	File	Size
new	3141913-18.patch	3.21 KB

Re-rolled after #2840876: Azure Datamarket has changed landed.

Comment #19

25 November 2021 at 16:58

heddn committed 8c02951 on 8.x-1.x

Issue #3141913 by adityasingh, heddn: Automated Drupal Rector fixes

Comment #20

heddn

English

Nicaragua

commented 25 November 2021 at 17:31

Status	File	Size
new	3141913-19.patch	6.39 KB

A few more things are needed.

Comment #21

25 November 2021 at 17:41

heddn committed e554dba on 8.x-1.x

Issue #3141913 by adityasingh, heddn: Automated Drupal Rector fixes

Comment #22

heddn

English

Nicaragua

commented 25 November 2021 at 17:41

Status:

Needs review

» Fixed

Comment #23

9 December 2021 at 17:44

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Automated Drupal Rector fixes

Problem/Motivation

Proposed resolution

Remaining tasks

Providing feedback

Comments

Comment #1

Comment #2

Comment #3

Comment #4

Comment #5

Comment #6

Comment #7

Comment #8

Comment #9

Comment #10

Comment #11

Comment #12

Comment #13

Comment #14

Comment #15

Comment #16

Comment #17

Comment #18

Comment #19

Comment #20

Comment #21

Comment #22

Comment #23

News items

Our community

Documentation

Drupal code base

Governance of community