Compatible with D9. So, Add core_version_requirement: ^8 || ^9 to info.yml file.

 [OK] No errors


 7/7 [============================] 100%
CommentFileSizeAuthor
#2 3139443-2.patch398 bytesdgaspara

Comments

dgaspara created an issue. See original summary.

dgaspara’s picture

dgaspara commented
StatusFileSize
new 3139443-2.patch398 bytes
kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Issue tags: -Drupal 9 porting day

Porting day was April 28th so removing tag.

  • joachim committed 3222739 on 8.x-2.x authored by dgaspara 
    Issue #3139443 by dgaspara: Updated info file for Drupal 9 readiness.

  • joachim committed 3222739 on 8.x-2.x authored by dgaspara 
    Issue #3139443 by dgaspara: Updated info file for Drupal 9 readiness.
manav’s picture

manav commented
Assigned: Unassigned » manav
Status: Needs review » Needs work

I have tried this patch on version 8.x-2.x-dev but it failed because the proposed patched code is already present in this branch.
So it giving below error:

git apply -v 3139443-2.patch
Checking patch garland.info.yml...
error: while searching for:
base theme: classy
description: 'A multi-column theme which can be configured to modify colors and switch between fixed and fluid width layouts.'
core: 8.x
libraries:
  - garland/global-styling
regions:

error: patch failed: garland.info.yml:3
error: garland.info.yml: patch does not apply
manav’s picture

manav commented
Assigned: manav » Unassigned
dgaspara’s picture

dgaspara commented

Hi Manav, this patch was applied yesterday by the maintainer (commit 3222739) therefore it could not be applied again.
However not sure why the status of this issues was not changed.

dgaspara’s picture

dgaspara commented
Status: Needs work » Needs review
manav’s picture

manav commented
Assigned: Unassigned » manav
Status: Needs review » Reviewed & tested by the community

As @dgaspara mentioned in #8, that maintainer has already applied this patch to branch,
so I am changing the status of this issue.

I have tested it on my local env and its working fine.

RTBC

manav’s picture

manav commented
Assigned: manav » Unassigned
joachim’s picture

joachim commented
Status: Reviewed & tested by the community » Fixed

Oops, I forgot to mark this as fixed. Sorry for the confusion!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.