Problem/Motivation

In Symfony 4.1 the EmailConstraint class changed the way it handled the 'strict' property, we added a compatibility layer to handle this. Now we are on Symfony 4.4 we can remove this compatibility layer again.

Proposed resolution

Remove the compatibility layer from the constructor.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3135305.patch1.21 KBlongwave

Comments

longwave created an issue. See original summary.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review
StatusFileSize
new 3135305.patch1.21 KB
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Parent issue: » #3136002: [meta] Remove compatibility shims for Symfony 4.3 and earlier
martin107’s picture

martin107 commented
Status: Needs review » Reviewed & tested by the community

In terms of review ..

a) Yep the logic of the issue is easy to follow
b) The patch cleans up all that is need to be cleaned up. Nothing over, Nothing under.
c) After look at the test results .. no additional errors ( just checking to be complete )

It will be nice to see this gone

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: 9.1.x-dev » 9.0.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 45447b2f90 to 9.1.x and d1e84f968f to 9.0.x. Thanks!

Backported to 9.0.x because this is dead code there too.

  • alexpott committed 45447b2 on 9.1.x 
    Issue #3135305 by longwave: Remove Symfony 4.1 compatibility layer from...

  • alexpott committed d1e84f9 on 9.0.x 
    Issue #3135305 by longwave: Remove Symfony 4.1 compatibility layer from...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.