• Fix ImageGen icon in CKEditor toolbar.
  • Fix image dimensions display
  • Review the code
Review of the 8.x-1.x branch (commit 47c473e):

    Your README.md does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
        The INTRODUCTION section is missing.
        The REQUIREMENTS section is missing.
        The INSTALLATION section is missing.
        The CONFIGURATION section is missing.
    Remove LICENSE.txt, it will be added by drupal.org packaging automatically.
    Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
    ESLint has found some issues with your code (please check the JavaScript coding standards). See attachment.
    No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script.


FILE: ...areviewsh/pareview_temp/src/Plugin/CKEditorPlugin/ImageGenButton.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 36 | ERROR | [x] Inline comments must end in full-stops, exclamation
    |       |     marks, colons, question marks, or closing parentheses
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...b/vendor/drupal/pareviewsh/pareview_temp/src/Controller/ImageGen.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 22 | ERROR | Doc comment for parameter $bg does not match actual
    |       | variable name 
--------------------------------------------------------------------------


FILE: ...web/vendor/drupal/pareviewsh/pareview_temp/src/Form/ImageGenForm.php
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------
  77 | ERROR | [x] No space found before comment text; expected "//
     |       |     Assigning the config 'image_gen.config' during
     |       |     buildForm." but found "//Assigning the config
     |       |     'image_gen.config' during buildForm."
 170 | ERROR | [x] No space found before comment text; expected "// Link
     |       |     to the content of this URL." but found "//Link to the
     |       |     content of this URL."
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Comments

yepa created an issue. See original summary.

yepa’s picture

Title: Improve the code & documentaion » Improve the code & documentation
Status: Active » Needs review
StatusFileSize
new0 bytes

  • yepa committed 583d8b5 on 8.x-1.x
    Issue #3132941 by yepa: Improve the code & documentation
    
yepa’s picture

Status: Needs review » Fixed
yepa’s picture

Status: Fixed » Closed (fixed)