Dependencies should be namespaced in the format {project}:{module}, where {project} is the project name as it appears in the Drupal.org.

According to
https://www.drupal.org/docs/8/creating-custom-modules/let-drupal-8-know-...

Comments

karishmaamin created an issue. See original summary.

karishmaamin’s picture

StatusFileSize
new686 bytes
karishmaamin’s picture

Status: Active » Needs review
seth.e.shaw’s picture

Status: Needs review » Needs work

Summary: The patch includes space between the namespace and the module name causing the module to fail loading.

Longer version: I applied the patch and cleared my cache which resorted in a pile of these warnings:

 [warning] strpos() expects parameter 1 to be string, array given Dependency.php:181
 [warning] explode() expects parameter 2 to be string, array given Dependency.php:182

and attempting to enable the module resulted in the following error:

In PmCommands.php line 271:

  Unable to install modules: module 'archivesspace' is missing its dependency module .

Removing the spaces between the namespace and the module name resolved the issue and the module loaded correctly.

Also, while we are doing this, could you also namespaces for the sub-module info files? I would appreciate it.

seth.e.shaw’s picture

StatusFileSize
new2.76 KB

New patch fixing the issues with #2 and adds namespaces to submodules.

  • seth.e.shaw authored 71f6693 on 8.x-1.x
    Issue #3131268 by karishmaamin, seth.e.shaw: Namespace dependencies in...
seth.e.shaw’s picture

Status: Needs work » Fixed
seth.e.shaw’s picture

Status: Fixed » Closed (fixed)