Drupal 9 readiness

before tagging this module as Drupal 9 compatible, you should first ensure that this is effectively the case. And this is not true. See

#3074066: Add EntityTypeBundleInfoInterface and EntityTypeManagerInterface as arguments for the parent constructor for EntityActivityContentEntityStorage
#3073475: Remove deprecated ConfigurablePluginInterface once support 8.6.x is dropped

And it could be anothers issues. A D9 check must be done before.

I've added merge requests to the 2 linked issues: #3074066 and #3073475.

Here is a patch that extends the above patch with some more fixes as reported by the upgrade status module.

Thanks. As #3073475: Remove deprecated ConfigurablePluginInterface once support 8.6.x is dropped introduce an Interface introduced in Drupal Core 8.7, we should drop support of version prior to 8.7

core_version_requirement should be at least core_version_requirement: ^8.7 || ^9, but this update should live in #3073475: Remove deprecated ConfigurablePluginInterface once support 8.6.x is dropped

But we could switch directly to ^8.8 and drop core: 8.x as 8.7 is unsupported since a long time :-)

I'd go a little crazy and bump up to 8.9 ;)
maybe make it a new major version, see 3211106

I try to update to drupal 9 with patch applied.
But when I user drush updatedb :
Unable to decode output into JSON: Syntax error

ArgumentCountError: Too few arguments to function Drupal\Core\Entity\Sql\SqlContentEntityStorage::__construct(), 6 passed in ../web/modules/contrib/entity_activity/src/EntityActivityContentEntityStorage.php on line 52 and exactly 8 expected in Drupal\Core\Entity\Sql\SqlContentEntityStorage->__construct() (line 180 of /home/digitalgreta/public_html/v2/web/core
/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorage.php).

hi @zorax, I dont have this error with the patch #7.

With a patch #7, I have got 6 errors (using drupal-check):
1 error for the LogGeneratorInterface.php file, it can be fix by this commit e81aadd5 - Remove deprecated ConfigurablePluginInterface.
5 errors for the unit test files.

We are so close to having a compatible module for Drupal 9

MR!4 looks good and tests are green (except some rewriting of arrays with new line but it's just coding standard). What is missing yet ?

Added a new test on PHP 7.3 & MariaDB 10.3.22, D9.2

Looks like it's just the property $defaultTheme that is missing in the test.

A final patch to complete D9 upgrade, based on MR4, for those who want/prefer a patch to test on a Drupal 9 Project.

Before committing this and tagging a new release compatible D9, can you test this on your Drupal 9 project and confirm that all is OK ?

No feedback. Let's commit this and see what happens on D9. Anyway the D8 version is now unsupported. Let's see this in follow up if necessary, it will be easier to fix potential remaining bugs. Thanks everyone.